From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83983 invoked by alias); 28 Jul 2015 15:04:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83972 invoked by uid 89); 28 Jul 2015 15:04:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 28 Jul 2015 15:04:37 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id A9.E8.00712.8A137B55; Tue, 28 Jul 2015 09:39:20 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.210.2; Tue, 28 Jul 2015 11:04:34 -0400 Message-ID: <55B79A02.40501@ericsson.com> Date: Tue, 28 Jul 2015 15:04:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 1/5] Update comment for struct type's length field, introduce type_length_units References: <1437072684-26565-1-git-send-email-simon.marchi@ericsson.com> <55B220F4.60706@redhat.com> <55B6A4A3.5050905@ericsson.com> <55B7573E.2030104@redhat.com> In-Reply-To: <55B7573E.2030104@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00824.txt.bz2 On 15-07-28 06:19 AM, Pedro Alves wrote: > On 07/27/2015 10:37 PM, Simon Marchi wrote: > >> Thanks for the review. Here is the updated version: > > Great, LGTM. Please push. > > Thanks, > Pedro Alves Ok, I pushed patches 1-4. I'll take some time later to better integrate the test (patch 5) with what is already there. Thanks! Simon