From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>,
"Breazeal, Don" <Don_Breazeal@mentor.com>,
Simon Marchi <simon.marchi@ericsson.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/N] remote follow fork and spurious child stops in non-stop mode
Date: Wed, 29 Jul 2015 15:40:00 -0000 [thread overview]
Message-ID: <55B8F3FC.9010108@redhat.com> (raw)
In-Reply-To: <55B8E1C4.9080605@redhat.com>
On 07/29/2015 03:23 PM, Pedro Alves wrote:
> On 07/29/2015 02:38 PM, Pedro Alves wrote:
>
>> Ignore the "SIGTRAP" mention in "SEL: Found 2 SIGTRAP events",
>> it's "two events". And the one that was picked was a process
>> exit. But the tail end of linux_wait_1 isn't expecting that
>> can happen.
>>
>
> This seems to fix it (and ends up making the code a little
> more like linux-nat.c). I'm running it through the testsuite.
It passes cleanly.
And I confirmed that that test idea triggers the suspend count
assertion I suspected:
Child exited with status 0
/home/pedro/gdb/mygit/build/../src/gdb/gdbserver/linux-low.c:2619: A problem internal to GDBserver has been detected.
unsuspend_one_lwp: Assertion `lwp->suspended >= 0' failed.
[Inferior 1 (process 32473) exited with code 01]
(gdb)
I'll convert that to a proper test.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-07-29 15:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 17:24 [PATCH v2 0/2] PR threads/18600: Threads left stopped after fork+thread spawn Pedro Alves
2015-07-23 17:25 ` [PATCH v2 1/2] " Pedro Alves
2015-07-30 18:08 ` [pushed] " Pedro Alves
2015-07-23 17:25 ` [PATCH v2 2/2] PR threads/18600: Inferiors left around " Pedro Alves
2015-07-23 18:21 ` [PATCH 3/N] remote follow fork and spurious child stops in non-stop mode Pedro Alves
2015-07-24 18:05 ` Simon Marchi
2015-07-24 18:17 ` Pedro Alves
2015-07-24 18:43 ` Don Breazeal
2015-07-29 13:21 ` Pedro Alves
2015-07-29 13:38 ` Pedro Alves
2015-07-29 14:23 ` Pedro Alves
2015-07-29 15:40 ` Pedro Alves [this message]
2015-07-29 16:40 ` Pedro Alves
2015-07-30 18:13 ` Pedro Alves
2015-07-30 18:15 ` Simon Marchi
2015-07-30 21:06 ` Don Breazeal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B8F3FC.9010108@redhat.com \
--to=palves@redhat.com \
--cc=Don_Breazeal@mentor.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).