From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77947 invoked by alias); 5 Aug 2015 15:10:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77930 invoked by uid 89); 5 Aug 2015 15:10:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 05 Aug 2015 15:10:16 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 5BCBFB6E60; Wed, 5 Aug 2015 15:10:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t75FADjZ012368; Wed, 5 Aug 2015 11:10:14 -0400 Message-ID: <55C22755.6080101@redhat.com> Date: Wed, 05 Aug 2015 15:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH/7.10 2/2] gdbserver: Fix non-stop / fork / step-over issues References: <1438362229-27653-1-git-send-email-palves@redhat.com> <1438362229-27653-3-git-send-email-palves@redhat.com> <86a8u8e754.fsf@gmail.com> <55BF94BC.6090904@redhat.com> <55C0EB12.9050209@redhat.com> <86k2tac68i.fsf@gmail.com> In-Reply-To: <86k2tac68i.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00115.txt.bz2 On 08/05/2015 12:41 PM, Yao Qi wrote: > Pedro Alves writes: > >> I've now extended the test to run in a few different modes, along >> a couple different axis. One axis is with/without conditional >> breakpoints on the target enabled. That exposes the same fails you >> saw on arm, on x86 gdbserver as well. And then the other axis is >> with/without joining _all_ threads before exiting. If we gracefully >> terminate the breakpoint thread (new mode), then the test should be >> passing everywhere, because what fails is gdb's handling of the inferior >> disappearing while a thread is stopped (and being inspected). >> Therefore that new mode is not kfailed. >> >> For testing convenience, I've pushed this along with the previous patch >> to the users/palves/gdbserver-fork-issues branch on sourceware.org. >> Let me know if this works for you. > > Thanks, Pedro. There are no fails on arm-linux with GDBserver. Some > comments on your patch below, Thanks Yao, that's great. Thinking about this some more made me want to split both the patch and test in two. The process-exits-while-handling-breakpoints issues happen independently of the fork issues, so I'll make the fork test always join all threads before exiting. Splitting will result in two cleaner and more directed tests. As per your testing, the fork test will not need any kfail. I'll be back to answer your questions and address your review when I have a moment. Thanks, Pedro Alves