public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v6 2/9] Explicit locations: introduce new struct event_location-based API
Date: Mon, 10 Aug 2015 18:05:00 -0000	[thread overview]
Message-ID: <55C8E7FB.3030106@redhat.com> (raw)
In-Reply-To: <m3d1yvdp5b.fsf@sspiff.org>

On 08/10/2015 10:33 AM, Doug Evans wrote:
> Later (not now, let's get this sucker checked in, unless of course
> you really want to), let's make event_location_to_string take a
> const struct event_location *, and make the cached copy
> "mutable in the c++ sense".

Bah. You got me on that one. This was used as part of the
pending-location hack ("append extra_string to the location") in
create_breakpoint:

      if (extra_string != NULL)
        {
          char *new = xstrprintf ("%s %s",
                                  event_location_to_string_const (location),
                                  extra_string);

          set_event_location_string (b->location, new);
          xfree (new);
        }

... which was removed in this revision, and I forgot to check if it was
being used at all anymore.

Answer: No, it is not used anymore. I could just remove it entirely.
Which is what I've done in my local copy. [Do you want me to repost this?]

Thanks!

Keith

  reply	other threads:[~2015-08-10 18:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 23:28 [PATCH v6 0/9] Series short description Keith Seitz
2015-08-05 23:29 ` [PATCH v6 1/9] Explicit locations: rename "address string"/"addr_string" to "location" Keith Seitz
2015-08-10 16:43   ` Doug Evans
2015-08-05 23:29 ` [PATCH v6 2/9] Explicit locations: introduce new struct event_location-based API Keith Seitz
2015-08-10 17:34   ` Doug Evans
2015-08-10 18:05     ` Keith Seitz [this message]
2015-08-10 19:59       ` Doug Evans
2015-08-11 20:45         ` [PATCH v6 2/9] Explicit locations: introduce new struct event_locations-based API Keith Seitz
2015-08-11 21:49           ` Doug Evans
2015-08-05 23:29 ` [PATCH v6 3/9] Explicit locations: use new location API Keith Seitz
2015-08-10 18:02   ` Doug Evans
2015-08-05 23:30 ` [PATCH v6 4/9] Explicit locations: introduce address locations Keith Seitz
2015-08-10 18:04   ` Doug Evans
2015-12-14  7:11   ` Joel Brobecker
2015-12-14 20:56     ` Keith Seitz
2015-12-15 13:40       ` Joel Brobecker
2016-01-17 15:32         ` [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches (was: "Re: [PATCH v6 4/9] Explicit locations: introduce address locations") Joel Brobecker
2016-01-18 21:29           ` [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches Keith Seitz
2016-01-21 10:33             ` Joel Brobecker
2015-08-05 23:30 ` [PATCH v6 5/9] Explicit locations: introduce probe locations Keith Seitz
2015-08-10 18:06   ` Doug Evans
2015-08-05 23:32 ` [PATCH v6 6/9] Explicit locations: introduce explicit locations Keith Seitz
2015-08-10 18:09   ` Doug Evans
2015-08-05 23:33 ` [PATCH v6 8/9] Explicit locations: MI support for " Keith Seitz
2015-08-10 19:43   ` Doug Evans
2015-08-05 23:33 ` [PATCH v6 7/9] Explicit locations: add UI features for CLI Keith Seitz
2015-08-10 19:42   ` Doug Evans
2015-08-11 20:45     ` Keith Seitz
2015-08-11 21:50       ` Doug Evans
2015-08-17 16:41       ` Yao Qi
2015-08-17 17:19         ` Keith Seitz
2015-08-05 23:34 ` [PATCH v6 9/9] Explicit locations: documentation updates Keith Seitz
2015-08-10 19:45   ` Doug Evans
2015-08-10 19:54 ` [PATCH v6 0/9] Series short description Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C8E7FB.3030106@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=xdje42@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).