Re: [PATCH, MIPS] Support shared library debug with MIPS PIE (gdb)

[Pedro Alves <palves@redhat.com>]

On 06/26/2015 01:45 PM, Matthew Fortune wrote:
> Joseph Myers <joseph@codesourcery.com> writes:
>> On Tue, 23 Jun 2015, Matthew Fortune wrote:
>>
>>> Please note that the new DT_MIPS_RLD_MAP2 support will not be enabled
>>> unless the host's elf.h header has the new tag defined in it. For
>>> cross compiled GDB this may mean hacking the solib-svr4.c file to
>>> define the macro until such time as distributions update glibc.
>>
>> That doesn't make any sense to me.  Hosts (e.g. MinGW) may not have
>> elf.h at all.  GDB should get these definitions from the #include
>> "elf/mips.h"
>> already in solib-svr4.c (i.e. from toplevel's include/elf/mips.h).  And
>> so there should be no #ifdefs there.

Thanks Joseph.

> Updated version below to match the name of the new tag as committed to
> binutils and removed the #ifdefs from solib-svr4.c.
> 
> binutils commit: a5499fa Add support for DT_MIPS_RLD_MAP_REL.
> 
> OK to commit?
> 

OK.

Thanks,
Pedro Alves