From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109432 invoked by alias); 9 Sep 2015 17:33:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109411 invoked by uid 89); 9 Sep 2015 17:33:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Sep 2015 17:33:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id BB1E745; Wed, 9 Sep 2015 17:33:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t89HX2hA032350; Wed, 9 Sep 2015 13:33:03 -0400 Message-ID: <55F06D4E.4020100@redhat.com> Date: Wed, 09 Sep 2015 17:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Replace continuations with an extendable "class" References: <1439398917-22761-1-git-send-email-palves@redhat.com> <86d1yk3gjb.fsf@gmail.com> In-Reply-To: <86d1yk3gjb.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00137.txt.bz2 On 08/18/2015 01:52 PM, Yao Qi wrote: > Pedro Alves writes: > >> Mainly, this series replaces the continuations mechanism with a >> "class" that manages a thread's execution-command-specific state. >> This fixes bugs, and cleans up core run control and interpreter code >> in the process, as well as clearing the path for further >> fixes/cleanups. > > Hi Pedro, > I go through this series, and sent my comments to some patches. > Overall, they look good to me. Thanks for the review Yao. I pushed this in now. -- Pedro Alves