From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 3/4] Extended-remote support for exec event tests
Date: Thu, 10 Sep 2015 13:26:00 -0000 [thread overview]
Message-ID: <55F184EE.8010903@redhat.com> (raw)
In-Reply-To: <1441839937-22251-4-git-send-email-donb@codesourcery.com>
Hi Don,
This is OK. One nit below.
On 09/10/2015 12:05 AM, Don Breazeal wrote:
>> Note that schedlock on has no effect in non-stop mode.
>> Maybe if !lock_sched && nonstop, we could issue "continue -a"
>> instead of continue.
>
> I couldn't find any documentation of 'continue -a'. (?) I just used
> a conditional to prevent running the lock_sched/nonstop tests.
I see that the "Continuing and Stepping" section doesn't mention
it. It's mentioned in "help continue", and here in the manual:
In non-stop mode, all execution commands apply only to the current thread
by default. That is, @code{continue} only continues one thread.
To continue all threads, issue @code{continue -a} or @code{c -a}.
> diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp b/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp
> index 69e5cc6..3e5c902 100644
> --- a/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp
> +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp
> @@ -28,11 +28,14 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
> return -1
> }
>
> -proc do_test { lock_sched } {
> - with_test_prefix "lock-sched$lock_sched" {
> +proc do_test { lock_sched nonstop } {
> + with_test_prefix "lock-sched$lock_sched,non-stop$nonstop" {
AFAICS, this will render as:
lock-schedoff,non-stopon
etc. I suggest adding a '=':
with_test_prefix "lock-sched=$lock_sched,non-stop=$nonstop" {
(in the other files too, of course.)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-09-10 13:26 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 21:49 [PATCH 0/5] Extended-remote follow exec Don Breazeal
2015-07-15 21:50 ` [PATCH 2/5] Extended-remote exec catchpoints Don Breazeal
2015-08-13 15:00 ` Pedro Alves
2015-07-15 21:50 ` [PATCH 1/5] Extended-remote exec events Don Breazeal
2015-07-16 14:01 ` Yao Qi
2015-07-16 15:52 ` Don Breazeal
2015-07-16 16:35 ` Yao Qi
2015-07-16 17:06 ` Don Breazeal
2015-07-17 11:55 ` Yao Qi
2015-07-15 21:50 ` [PATCH 3/5] Extended-remote support for exec event tests Don Breazeal
2015-07-15 21:51 ` [PATCH 5/5] Extended-remote exec event docs Don Breazeal
2015-07-16 2:39 ` Eli Zaretskii
2015-07-15 21:51 ` [PATCH 4/5] Eliminate spurious warnings from remote exec Don Breazeal
2015-07-30 23:19 ` [PATCH v2 0/5] Extended-remote exec events Don Breazeal
2015-07-30 23:19 ` [PATCH v2 1/5] Extended-remote follow exec Don Breazeal
2015-08-13 14:50 ` Pedro Alves
2015-07-30 23:19 ` [PATCH v2 2/5] Extended-remote exec catchpoints Don Breazeal
2015-07-30 23:20 ` [PATCH v2 3/5] Extended-remote support for exec event tests Don Breazeal
2015-08-13 15:22 ` Pedro Alves
2015-07-30 23:20 ` [PATCH v2 4/5] Eliminate spurious warnings from remote exec Don Breazeal
2015-08-13 15:38 ` Pedro Alves
2015-07-30 23:20 ` [PATCH v2 5/5] Extended-remote exec event docs Don Breazeal
2015-07-31 6:36 ` Eli Zaretskii
2015-07-31 17:06 ` Don Breazeal
2015-08-13 15:43 ` Pedro Alves
2015-09-09 23:05 ` [PATCH v3 0/4] Extended-remote exec events Don Breazeal
2015-09-09 23:06 ` [PATCH v3 3/4] Extended-remote support for exec event tests Don Breazeal
2015-09-10 13:26 ` Pedro Alves [this message]
2015-09-09 23:06 ` [PATCH v3 4/4] Extended-remote exec event docs Don Breazeal
2015-09-10 15:23 ` Eli Zaretskii
2015-09-09 23:06 ` [PATCH v3 2/4] Extended-remote exec catchpoints Don Breazeal
2015-09-09 23:06 ` [PATCH v3 1/4] Extended-remote follow exec Don Breazeal
2015-09-10 12:43 ` Pedro Alves
2015-09-10 22:56 ` Don Breazeal
2015-09-10 23:00 ` Don Breazeal
2015-09-11 8:34 ` Pedro Alves
2015-09-11 18:38 ` [pushed][PATCH " Don Breazeal
2015-09-11 18:38 ` [pushed][PATCH v3 3/4] Extended-remote exec test Don Breazeal
2015-09-15 15:45 ` Pedro Alves
2015-09-15 15:53 ` Don Breazeal
2015-09-15 15:58 ` Pedro Alves
2015-09-15 16:00 ` Breazeal, Don
2015-09-15 16:28 ` Pedro Alves
2015-09-11 18:38 ` [pushed][PATCH v3 2/4] Extended-remote exec catchpoints Don Breazeal
2015-09-11 18:39 ` [pushed][PATCH v3 4/4] Extended-remote exec event docs Don Breazeal
2015-09-15 8:56 ` [pushed][PATCH v3 1/4] Extended-remote follow exec Yao Qi
2015-09-15 16:12 ` Don Breazeal
2015-09-15 16:31 ` Yao Qi
2015-09-30 16:20 ` Pedro Alves
2015-09-30 16:22 ` Breazeal, Don
2016-12-08 11:54 ` Thomas Schwinge
2017-02-17 16:45 ` Pedro Alves
2019-02-14 16:42 ` Thomas Schwinge
2019-02-14 17:26 ` Tom Tromey
2019-02-14 23:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F184EE.8010903@redhat.com \
--to=palves@redhat.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).