From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79831 invoked by alias); 11 Sep 2015 12:43:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79822 invoked by uid 89); 11 Sep 2015 12:43:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 11 Sep 2015 12:43:38 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id D8.8E.26730.FC162F55; Fri, 11 Sep 2015 07:08:31 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Fri, 11 Sep 2015 08:43:36 -0400 Subject: Re: [PATCH 7/7] Support tracepoints and software breakpoints on ARM aarch32-linux in GDBServer. To: Eli Zaretskii References: <1441973603-15247-1-git-send-email-antoine.tremblay@ericsson.com> <1441973603-15247-8-git-send-email-antoine.tremblay@ericsson.com> <83613h3zqf.fsf@gnu.org> CC: From: Antoine Tremblay Message-ID: <55F2CC78.4080008@ericsson.com> Date: Fri, 11 Sep 2015 12:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <83613h3zqf.fsf@gnu.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00230.txt.bz2 On 09/11/2015 08:30 AM, Eli Zaretskii wrote: >> -@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}]@r{[}-@r{]} >> +@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}][:K@var{kind}]@r{[}-@r{]} >> @cindex @samp{QTDP} packet >> Create a new tracepoint, number @var{n}, at @var{addr}. If @var{ena} >> is @samp{E}, then the tracepoint is enabled; if it is @samp{D}, then >> -the tracepoint is disabled. The @var{step} gives the tracepoint's step >> -count, and @var{pass} gives its pass count. If an @samp{F} is present, >> -then the tracepoint is to be a fast tracepoint, and the @var{flen} is >> -the number of bytes that the target should copy elsewhere to make room >> -for the tracepoint. If an @samp{X} is present, it introduces a >> -tracepoint condition, which consists of a hexadecimal length, followed >> -by a comma and hex-encoded bytes, in a manner similar to action >> -encodings as described below. If the trailing @samp{-} is present, >> -further @samp{QTDP} packets will follow to specify this tracepoint's >> -actions. >> +the tracepoint is disabled. The @var{step} gives the tracepoint's >> +step count, and @var{pass} gives its pass count. If an @samp{F} is >> +present, then the tracepoint is to be a fast tracepoint, and the >> +@var{flen} is the number of bytes that the target should copy >> +elsewhere to make room for the tracepoint. If an @samp{X} is present, >> +it introduces a tracepoint condition, which consists of a hexadecimal >> +length, followed by a comma and hex-encoded bytes, in a manner similar > > Please in the future try not to re-fill previous text: it makes harder > for me to find your changes among a potentially large paragraph, such > as this one. OK sorry about that. > >> +to action encodings as described below. If a @samp{K} is present, it >> +indicates a target specific breakpoint length. E.g., the arm and mips >> +can insert either a 2 or 4 byte breakpoint. Some architectures have >> +additional meanings for kind see : @ref{Architecture-Specific Protocol >> +Details} . > > There's no need for the colon ':' after "see", and please delete the > space before the period that ends the last sentence above. Done > > Otherwise, the documentation parts are OK. Thanks. > Thanks.