From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9199 invoked by alias); 11 Sep 2015 15:52:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9185 invoked by uid 89); 11 Sep 2015 15:52:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Sep 2015 15:52:04 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-5-4lrDuegsS_67qz8HO04iYQ-1; Fri, 11 Sep 2015 16:52:00 +0100 Received: from [10.2.206.88] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 11 Sep 2015 16:51:59 +0100 Message-ID: <55F2F8A0.9000804@arm.com> Date: Fri, 11 Sep 2015 15:52:00 -0000 From: Pierre Langlois User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yao Qi CC: pierre.langlois@arm.com, "gdb-patches@sourceware.org" Subject: Re: [PATCH] [AArch64] Fix incorrect mask when decoding b.cond instruction References: <1441963216-8139-1-git-send-email-pierre.langlois@arm.com> <86k2rx55qi.fsf@gmail.com> In-Reply-To: <86k2rx55qi.fsf@gmail.com> X-MC-Unique: 4lrDuegsS_67qz8HO04iYQ-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00236.txt.bz2 On 11/09/15 16:35, Yao Qi wrote: > Pierre Langlois writes: >=20 >> The encoding of the b.cond instruction is described in the architecture >> reference manual as: >> >> b.cond 0101 0100 iiii iiii iiii iiii iii0 cccc >> >> So the mask should be 0xff000010. >> >> I've regression tested it on aarch64-linux, I haven't seen any difference >> with or without the patch. >=20 > Hi Pierre, > You posted this patch here > https://sourceware.org/ml/gdb-patches/2015-08/msg00421.html and I > reviewed it. The patch is OK. >=20 Oops, sorry for posting this again. I've pushed it now. Thanks, Pierre