From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61995 invoked by alias); 21 Sep 2015 17:49:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61985 invoked by uid 89); 21 Sep 2015 17:49:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Sep 2015 17:49:32 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 9D.34.32596.B14EFF55; Mon, 21 Sep 2015 13:03:55 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Mon, 21 Sep 2015 13:49:29 -0400 Subject: Re: [PATCH 2/7] Move some integer operations to common. To: Pedro Alves , Gary Benson References: <1441973603-15247-1-git-send-email-antoine.tremblay@ericsson.com> <1441973603-15247-3-git-send-email-antoine.tremblay@ericsson.com> <20150911142442.GA23515@blade.nx> <55F30C55.3080507@ericsson.com> <55F31019.1080607@ericsson.com> <20150914092453.GA26894@blade.nx> <55F6E5BC.7050006@ericsson.com> <20150921091007.GA23767@blade.nx> <55FFCAF2.5040400@redhat.com> CC: From: Antoine Tremblay Message-ID: <56004326.50507@ericsson.com> Date: Mon, 21 Sep 2015 17:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55FFCAF2.5040400@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00513.txt.bz2 On 09/21/2015 05:16 AM, Pedro Alves wrote: > On 09/21/2015 10:10 AM, Gary Benson wrote: >> Hi Antoine, Pedro, >> >> Antoine Tremblay wrote: > >>> So I've made bfd.h a requirement of GDBServer, and when there will >>> be a libgdbcommon we can have the whole lib as a requirement there. >>> >>> See patch v2 in next mail... >> >> I don't think this will be acceptable. If I understand correctly, >> gdbserver supports some platforms that GDB (and BFD) does not, and >> this patch would prevent gdbserver being built on those platforms. >> Even if I'm wrong here, I've previously found it useful to build >> gdbserver alone, and I think this would break that too. >> >> Pedro knows more about these kinds of setups, I've copied him in. >> > > (Without looking at the patch in detail), > > Gary's right. bfd.h is a generated file, generated at bfd build time. > Anton, try building only gdbserver in a clean directory, > separate from gdb, and it will fail with your patch. > Ok I was worried this would not work.. I've removed much of the endianness dependencies from my patchset but I still have a dependency on the bfd endiannness enum to share code with GDB's read_memory_unsigned_integer. So I will do a wrapper around read_memory_unsigned_integer in GDB that takes an int and transfers it to the real read_memory_unsigned_integer as the proper enum (by implicit conversion). And use an int when referring to the enum in shared code. Unless there's an objection to this method ?