From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119025 invoked by alias); 29 Sep 2015 11:55:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118996 invoked by uid 89); 29 Sep 2015 11:55:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 29 Sep 2015 11:55:07 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 53.09.32596.3AC1A065; Tue, 29 Sep 2015 07:07:47 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.248.2; Tue, 29 Sep 2015 07:55:05 -0400 Subject: Re: [PATCH 4/5] Handle breakpoint kinds for software breakpoints in GDBServer. To: Yao Qi References: <1442577749-6650-1-git-send-email-antoine.tremblay@ericsson.com> <1442577749-6650-5-git-send-email-antoine.tremblay@ericsson.com> <86y4fq7s0d.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <560A7C18.7090309@ericsson.com> Date: Tue, 29 Sep 2015 11:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <86y4fq7s0d.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00631.txt.bz2 On 09/28/2015 06:33 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h >> index 603819e..bf4c3c7 100644 >> --- a/gdb/gdbserver/target.h >> +++ b/gdb/gdbserver/target.h >> @@ -446,6 +446,10 @@ struct target_ops >> can be NULL, the default breakpoint for the target should be returned in >> this case. */ >> const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *lenptr); >> + >> + /* Returns a breakpoint from a length, the length can have target specific >> + meaning like the z0 kind parameter. */ >> + const unsigned char *(*breakpoint_from_length) (int *len); >> }; > > If you agree on my comments to patch 2/5, we can rename this hook to > breakpoint_from_z0_kind. > I've renamed this to breakpoint_from_kind since I want to be able to reuse the same operation for future tracepoint kinds and don't want the confusion with z0. This follows the terminology introduced in patch 2/5 in general too.