From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125661 invoked by alias); 30 Sep 2015 16:20:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125647 invoked by uid 89); 30 Sep 2015 16:20:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Sep 2015 16:20:11 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 92296A2C36; Wed, 30 Sep 2015 16:20:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8UGK8be028189; Wed, 30 Sep 2015 12:20:09 -0400 Message-ID: <560C0BB8.30804@redhat.com> Date: Wed, 30 Sep 2015 16:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [pushed][PATCH v3 1/4] Extended-remote follow exec References: <1441996698-12694-1-git-send-email-donb@codesourcery.com> In-Reply-To: <1441996698-12694-1-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00670.txt.bz2 Hi Don, On 09/11/2015 07:38 PM, Don Breazeal wrote: > @@ -5977,6 +6065,7 @@ remote_parse_stop_reply (char *buf, struct stop_reply *event) > struct remote_arch_state *rsa = get_remote_arch_state (); > ULONGEST addr; > char *p; > + int skipregs = 0; > > event->ptid = null_ptid; > event->rs = get_remote_state (); > @@ -6089,11 +6178,42 @@ Packet: '%s'\n"), > event->ws.kind = TARGET_WAITKIND_VFORK_DONE; > p = skip_to_semicolon (p1 + 1); > } > + else if (strncmp (p, "exec", p1 - p) == 0) > + { I happened to notice that this is still using strncmp while the rest of the magic registers are now using strprefix instead (26d56a939e). Looks like a mid-air collision happened. This one could be adjusted to use strprefix too, right? Thanks, Pedro Alves