From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125665 invoked by alias); 22 Oct 2015 13:55:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125655 invoked by uid 89); 22 Oct 2015 13:55:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 22 Oct 2015 13:55:47 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 97.B4.26730.C1E78265; Thu, 22 Oct 2015 08:11:40 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.248.2; Thu, 22 Oct 2015 09:55:44 -0400 Subject: Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer. To: Ulrich Weigand References: <20151022134952.1AF5AF738@oc7340732750.ibm.com> CC: , From: Antoine Tremblay Message-ID: <5628EAE0.6010402@ericsson.com> Date: Thu, 22 Oct 2015 15:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151022134952.1AF5AF738@oc7340732750.ibm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00470.txt.bz2 On 10/22/2015 09:49 AM, Ulrich Weigand wrote: > Antoine Tremblay wrote: > >> gdb/gdbserver/ChangeLog: >> * mem-break.c : Remove breakpoint_data/breakpoint_len global variables. >> (set_breakpoint_data): Remove. > > This breaks building gdbserver for spu-elf: > > spu-low.o: In function `initialize_low': > gdb/gdbserver/spu-low.c:684: undefined reference to `set_breakpoint_data' > > and most likely other non-Linux gdbserver targets that still refer to > set_breakpoint_data: > > gdb/gdbserver/nto-low.c: set_breakpoint_data (the_low_target.breakpoint, > gdb/gdbserver/win32-low.c: set_breakpoint_data (the_low_target.breakpoint, > > What needs to be done to fix those? > Right, I need to implement the breakpoint_kind_from_pc and breakpoint_from_kind in non-linux targets. I'll send a patch soon. > B.t.w. if set_breakpoint_data is really gone, its prototype should be > removed from mem-break.h as well. > Indeed will patch this too.