From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89886 invoked by alias); 30 May 2018 14:54:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89859 invoked by uid 89); 30 May 2018 14:54:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 May 2018 14:54:43 +0000 Received: from ESESSHC016.ericsson.se (Unknown_Domain [153.88.183.66]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 11.EB.24558.03BBE0B5; Wed, 30 May 2018 16:54:40 +0200 (CEST) Received: from ESESSMR501.ericsson.se (153.88.183.108) by ESESSHC016.ericsson.se (153.88.183.66) with Microsoft SMTP Server (TLS) id 14.3.382.0; Wed, 30 May 2018 16:53:27 +0200 Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSMR501.ericsson.se (153.88.183.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 30 May 2018 16:53:27 +0200 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 30 May 2018 16:53:26 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.220] (192.75.88.130) by DM6PR15MB2393.namprd15.prod.outlook.com (2603:10b6:5:8d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.797.11; Wed, 30 May 2018 14:53:25 +0000 Subject: Re: [PATCH]: Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha To: Uros Bizjak , CC: Richard Henderson , Tobias Klausmann References: From: Simon Marchi Message-ID: <56293ba8-f95b-5da1-af14-7500a0f8f892@ericsson.com> Date: Wed, 30 May 2018 18:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0201CA0057.namprd02.prod.outlook.com (2603:10b6:803:20::19) To DM6PR15MB2393.namprd15.prod.outlook.com (2603:10b6:5:8d::27) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM6PR15MB2393; X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;3:jCV5LuTuBXFWsLX/l4BMCrU+EHdN3cPZiwIL49cmx70kBtmIVmg+60SHVGgPwT1mlt5XP0W0NylxJsVMp61xI3I8FWRAq9lLCXmZjhUPBXL7rGPGmsv5vlCYybr+Seu1VMgB9f/pfPPLi/Ut+vbNpe/nZul9DOMDbFOnenHOMa3jUJAGYaYp+614ZCiP+aNoMSjF3eBdaRHGe57oR42XNUMc2PO3mqaQjMpkWUAurxIkbdmQcQ90WjpAOHzZX3Gb;25:Bk+01YKJGwiu75mCS3FPgODQeIysqL3BTntpNieygc+nXOXbUc0lNijXzvJqTLkfI3L/GiIhrxMBpGh/fnlQVD6Hvs/rv+NTxileaMIFPduc3xSIn1YyWqNGnr56jygYr5kR9/XsMoWADLYRe1t6zau4au4UkDAJpHU+Yky1vdrrjRqRG1p7eTCLK7LVQTHZ8/y/igS1WMP2sARG1HIZq7QkguWc6kV7nKF4a23OoOgefEZCfqlSKVWfByZE0KJ2OmcQGS2eg1TvSgdE7+hX4V1NVgOu7uWnGLpwA+iciUNKb26SPKTwCq7vCT/GU7ZA3HkYtxX9oFN7eJf0llM2uQ==;31:4evWvYjfOg5qTdFSTJxz8f3f05W+aQCTwp3aKLU106mAZ9J/JQfImYz+0Lz51leywxp7CqZ6hGHhTduwj7Jdj0DHEKuLhr6y31OMqb/iQxOqm8b8pKHSGRMqZt8s88vvnP49RfWcvr0OtsHSFKYqgC4ECyERNBnGLTYl2wbtr+R5RSUfb1svWGYwLayB5B3sEC+g3XQHKaLBLKmkkHjuLHyo7ew+1zbD3xdjKW3ryKk= X-MS-TrafficTypeDiagnostic: DM6PR15MB2393: X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;20:bmk9ACuFxISuNmt8aFb1KyoKLFCw2pSGds4gxcxKOrMH8AaxxXgMmDNFH3kfOgiLRGuB9gx6OolQyRAJ+ZhCysn9ZEGwb7g3k04y3VYxK69BuOgZmkHzaSzyiYcWhj7dMovfI1tYsMrMZvPlwvIDH4O2/3RC/ruswY155ZaiTB6E5KUwi3atk3iKYSbmY3oaWvgwo2X7bCHTeG8F2O1qF3XbUrPybMXHfZJmBKy1PpojpLfHvu40ODFKpzpvIJOVGSLnOXAIMM0V5xYZrRPfY5evJ5Ks3reqW8g6X3yOt2O+NE3lQkWCeiVCf8ncezPxHnKCfKyopO792PYCEj799YahL97dlx7B5SMfJCzoZwPQRZR4gtP2v+CwkSj8qKVVt5atB1dtVi1sA/moM0ciy8DlLV0eb6ED1erBka2RVW93/EwDdltVTmr+OOfrQWhDyBpkNIArxRUeZ5mWCWKP8ECRPhIfqjpKU9BlBtMaNrsBVbHlm/QcDekD98nYSgIt;4:H9BHKSaXSq9Aet2Jj1idk/D5KvQjXNgZ0VTWBMTNtL1Yal/2rIy4ELmC3iRZSHVvThFZsY69NE9dAueu2Rs6R3KBbODVdt52fC0bCtXryIoWEMQeBH0ipuE5RII57fqJHC0Mi52qBxn/T0W4C+SwYrX3ytoZxUNeB+53X09fWhA8yZTuFDPHxxFSZb0MkXE4MAp57vFucf1KTBMjhxyvsnx9cG2yJvoI56FJaF7uyvo7Wl9puAt6OOmK6tlbQgOvBpQpOmaDWoiZiwMaXOtO6C8ks2ZggIz4lHJNtCQUdQ9wHBI2kAuGstP23O4FJVIp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016);SRVR:DM6PR15MB2393;BCL:0;PCL:0;RULEID:;SRVR:DM6PR15MB2393; X-Forefront-PRVS: 0688BF9B46 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(39380400002)(39860400002)(376002)(396003)(346002)(199004)(189003)(6116002)(6306002)(66066001)(105586002)(966005)(3846002)(4326008)(230700001)(86362001)(23676004)(2486003)(65806001)(52116002)(65956001)(68736007)(50466002)(31696002)(53936002)(229853002)(7736002)(305945005)(53546011)(52146003)(478600001)(59450400001)(386003)(26005)(54906003)(49976009)(6486002)(97736004)(47776003)(446003)(186003)(16526019)(39060400002)(16576012)(8676002)(6246003)(58126008)(36756003)(486006)(76176011)(316002)(8936002)(5890100001)(476003)(81156014)(11346002)(81166006)(956004)(31686004)(2906002)(65826007)(64126003)(6666003)(25786009)(44832011)(5660300001)(4001150100001)(2616005)(106356001)(78286006)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR15MB2393;H:[142.133.49.220];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTZQUjE1TUIyMzkzOzIzOkJZN1ViT2I3Y0ZHTlNuRWU2U3JrWVJsNHZu?= =?utf-8?B?NUg5bVJoODF4MGVjWE03ZnQ0aFV2V21GM0tvalVqbUNnWEF6dk95SW9UVWx5?= =?utf-8?B?L3JDZkxES3EvMVRyUDY1emRuUzFoRWJBT29kOHZSRVFKMGpmMkIyOEdzR1Bh?= =?utf-8?B?MnUvakJXSERNUDgyT3FMWEdBRXZIcjRWTEJxay9aKzlIamFWY1Q3SmF5NUlr?= =?utf-8?B?ZUU2WUlRdWsxNll6M2pKUVNPQXdRWTZlN3p5RmhZUTFZZE5oWHdyOExpcDBq?= =?utf-8?B?V2l1d2JSdXFQTWdZTjA5ZGo3WjVvaXNRNlFlZW1FQW9UbkVLdVlJUnJISWp3?= =?utf-8?B?N2VXZ2pxOUlTdUt5Yk1XRVJ5SnJBZ3dDM1JaS0xraFBQUm9KVHh6WmdVZnlS?= =?utf-8?B?ZFFqUmh2OURRMFVlNUlmbC9OaWIza3lybWxhdUxBVmpFSFRvcnhYanozVFY5?= =?utf-8?B?eUJPTWxWVjZxbnVaZXp4SmtFNnJKUU52ZmNodEdVSjd6WUpFUEpML0duSTJl?= =?utf-8?B?RVFkcnYrK1VIN3RHdG1RVXV3OW5tak12MmpuWG82bEtJTDZuczR6MVZTMVU2?= =?utf-8?B?K0tRSVV5UDhyZUhtNWJ3WkNrMDdYM0FCWTNoZUtKWm9yZnMxNHVnL1FqL05O?= =?utf-8?B?OVM5OXU0ZFY2VWU4cXVUbER2eWg3c3dLMEpNQ1pDVkovaVVKeVEwS2FyVlA5?= =?utf-8?B?TXRtenNzS2l4c0Yzb2pBeUZBank0MUdmVnhvNEMvVTNmYXJNZisxc2ptdXFE?= =?utf-8?B?cm9vNmhpRk9EN0pQQ1o5aXVBTW5oVVNsQitzaFQyMTlEdEhsWk02QUJseGdj?= =?utf-8?B?WjgrQ3crMXRZN0k5NmNBN1A5K3F5SXZRUk4vQ1E2a0FBVk4rVU9NWFZTMFBn?= =?utf-8?B?S0szMEFuMjN4aWIrYUVTazVKaWF6dWpXdlRPVDVYWjU3am03dDRqVTdBbWxT?= =?utf-8?B?N1dtUldFK25sZWI3V3FjdGJlcDlidVlpdlZaSWJ3NC9NK2NWZjNJMFVMa1dT?= =?utf-8?B?Y1h2Q0t1UENjYTNzejZmVTAzM3NTR252Y0pJbW1QN2d0cUVMSHkrYkZ2S1VF?= =?utf-8?B?SU03bFdsTXVQMkV3dnFYMDdiQWc5b3ZTTGJPeFFEdjhyN2dvWXViN0JXWVRK?= =?utf-8?B?KzY3c0F6VTY4TkFlZEF5blhWaEtyWkpiaCtHOWVPMWdXbG02aEdDd1lNVWJx?= =?utf-8?B?NlNQVk9qc1M2eGs3blFPZDBuRUYrTm9hMC9XY2Rnbzk1SGprMGFJYUQ0WUNY?= =?utf-8?B?L3NPNDhWaHlEYmNsRjJvenJKbkdNdDdtYXg5MFJYblVkamd1cTA1bklMTDJT?= =?utf-8?B?UVNiTWkvZDVDN2NUZXlCalJ2YVhXNlNmemZxVjN6RTBGOUxaNWVKVUtJNVBK?= =?utf-8?B?d08xUkVoa1AvbXdqYnFKM2R3cFVLR1pKU0JhZlNJOWEvTllMT21JOFFtWEU2?= =?utf-8?B?cWpFa0QxTzFaa0daeXZ5azJHdk5GblhDYkVVQUNsYk80YjRjTThNcUprMTJF?= =?utf-8?B?UFdFOTZ1cFNKUUJ1TWhQa1orbnl6YktjakdTdCtTYVZuTlFHLzJsaytRUUU3?= =?utf-8?B?d0lCR2tpOXlvMEgzNUd0N1YycG54dlVwZnBBTFY0cEdDTlM0QXA0SExycWhP?= =?utf-8?B?VGUrZy9NaStEcm9FWElyenZHK3ZQTmJsQWc5SFBxNlBVaWc0MHYyNXpzbzdX?= =?utf-8?B?Q2NLaXhRWllOOVpvc093eW50TnM5RTBsWkwxSGFRK1JSa0NMWTFXWFFjcEtj?= =?utf-8?B?ekoyMlY0aVEzRXVWYzRlTFl2UmgwQll5M2FpbGlHVXJTTEQwWDdVVnFWeHl5?= =?utf-8?B?WmZiU1IvVmRWL0NsejcwME5WaVRobGJWYjQ5UkFuazJWVHcvSzRmSDhjSUV4?= =?utf-8?B?M0N1WkZHWjFTQ3R5anBJTlB2UExsbkcxallUUWl0elY0ZWtZUGNDYUFzY1Ex?= =?utf-8?B?cERXMS9qeGJrREtvOHByd2tVRlU1NENSQkxjL2VzVkR3YVhOVUFpZGRpdGF4?= =?utf-8?B?cmVFMWVPMUZtMUhnaFNQRTFEakdFYXZ2RGlZN3EzVUx2N0QyeVRJbk1Mcitk?= =?utf-8?B?NEdGMkdSMVU1VDB2a2RrQUdhOGhXYUlBT085L3RqSXRReVBWM2xCOVV5dmVG?= =?utf-8?B?YWRYVmtLTmFneU1xWUh1MHN1U0lCRUhaYVh2ZlRaNUdxNmdUQ0FZazJONGI1?= =?utf-8?Q?3rKfJe2ov8pdvCnXjKERnAG0whMjPbissCwWIk3ogg=3D?= X-Microsoft-Antispam-Message-Info: hifaGhceSoqXtepBGG0WAmOVScFVYnSmrCerqs+Z/8agsxKDulRSRFc0C5p/6SYCvX5EsxRJTeBMgb9h9sraZTI3s0C8JeF15sFnmrWDyWYhfetrQfT+XjBw+HLMAxzsDG+/YHyWbls3avsakP6tM7ShxxWKwhGD8dGFb9iELN90J0s6Lym5dBItwBS9c8co X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;6:zVR5vmD4HZKd0A27MoDckyXixeSBe26+oGPgvFUfTlLOKYW7jIoEClq3fMTlBSSbWsZvbxdeSBDjtxszdbzUbGzEwOYYQ93MpUsb81QQrh/34JQUq2FkO/MkBMkYIryyYBfiVqyH5/q4OEXdxpaH0PfslX/AatrGUBPGmMJxYgjrYGcHw8nbTJoaYrlVRkQ9DORRJaRDpcS+syISemDiKX9OO3+mQu/hCdvTsaYVOxa6SBi0i3/zmbXLYNU9EzDEo2xKr3EqDFrMj3lSRTeOUqNb+oIyxaceAMCJd0Pl1tnOEtUMtYFRNkLYyP1aw8gnb8NJnXYUYJtmWKWtykUTcrCFBAG1awBSTilPB1I/v17zlR/Zg/gIyVrkjMFntNtYCBM4hmpkv/3T91PeFPyjxqTAbNh8s2zTF5RPCMAEaqdPAR8QG/YahzcCWs0zQdG7j+5XUFZ/fk68w1R6rbNBmQ==;5:oEZ7UFwyoIrqlYW122LdxWgZaTvWbHXhuAIkghvuuA6P4GMij6FYnqspRm9yC6McCyaw3nRnw7BuFyqict+q+4spXsqT2pd+4hD/LYmt3PHTstGZMmIF/kgu3ymFlW3Ej5eUpwy0frKu8FF2Y1bISrgFEzTpyjJulbS+RvztKJI=;24:rHHMGphTIxUHTaA/2KAl8ro9p6pFfSpEdp9MZteShNLHNd345tHtTsogqF4xV4b1zPYCu5+QJ5ZM+ac1kkb3bLcOGzTJjDG5eVJI6yuthAY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;7:aHa4pyF9fAsEnUcaU4i3sRdzLXe5m46+Lmq8qYFBrvTQpbQ6GGhlndjy04fzkqw0R2QiN9QfUQ+nA5UfCG1MXdb7NYdDlmyqfsF4ffcNvLaBkxrK5QYjKkdX2LG8BuP1PMO3gW5CI7z9z7b3F6n2+9MYp4RJcw4YMITYdALdElz0bsUF/L8S2q0XiwQg3xTgVJbUkdv3WMJHNwWZefm1pLwHVvqt0lO+4tmGOalIxCaZjjGZ6VxOkwyAAnawvmnW X-MS-Office365-Filtering-Correlation-Id: 6bf9d02a-a4a4-4097-378f-08d5c63d18ea X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2018 14:53:25.0788 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf9d02a-a4a4-4097-378f-08d5c63d18ea X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2393 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00794.txt.bz2 On 2017-12-15 07:11 AM, Uros Bizjak wrote: > Hello! > > Attached patch fixes PR19061, where gdb hangs/spins-on-cpu when > debugging any program on Alpha. The patch is effectively a forward > port of Richard's patch from the Comment #5 of the PR [1]. > > > 2017-12-15 Uros Bizjak > Richard Henderson > > PR gdb/19061 > * alpha-tdep.c (alpha_software_single_step): Call > alpha_deal_with_atomic_sequence here. > (set_gdbarch_software_single_step): Set to alpha_software_single_step. > * nat/linux-ptrace.h [__alpha__]: Define GDB_ARCH_IS_TRAP_BRKPT > and GDB_ARCH_IS_TRAP_HWBKPT. > > Patch was tested on alphaev68-linux-gnu, also tested with gcc's > testsuite, where it fixed all hangs in guality.exp and > simulate-thread.exp testcases. > > Please note that I have no commit access, so if approved, please > commit the patch to the source repository for me. I also have > functionally equivalent patch for gdb-8 branch which I plan to submit > later. > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=19061#c5 > > Uros. > Hi Uros and Richard, I would need your input. Using this cross-compiler: alphaev67-unknown-linux-gnu-gcc (crosstool-NG crosstool-ng-1.22.0-677-ga3dd55b9) 6.3.0 Copyright (C) 2016 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. I get this error: CXX linux-nat.o /home/simark/src/binutils-gdb/gdb/linux-nat.c: In function 'void save_stop_reason(lwp_info*)': /home/simark/src/binutils-gdb/gdb/linux-nat.c:2718:9: error: duplicated 'if' condition [-Werror=duplicated-cond] else if (GDB_ARCH_IS_TRAP_HWBKPT (siginfo.si_code)) ^~ In file included from /home/simark/src/binutils-gdb/gdb/linux-nat.c:31:0: /home/simark/src/binutils-gdb/gdb/nat/linux-ptrace.h:173:41: note: previously used here # define GDB_ARCH_IS_TRAP_BRKPT(X) ((X) == TRAP_BRKPT) ~~~~~^~~~~~~~~~~~~~ /home/simark/src/binutils-gdb/gdb/linux-nat.c:2709:13: note: in expansion of macro 'GDB_ARCH_IS_TRAP_BRKPT' else if (GDB_ARCH_IS_TRAP_BRKPT (siginfo.si_code)) ^~~~~~~~~~~~~~~~~~~~~~ Does Alpha even have hardware breakpoints? If not, I would suggest defining GDB_ARCH_IS_TRAP_HWBKPT to 0 for __alpha__. It would get rid of the error, and be more exact (no si_code can mean "hardware breakpoint" on alpha). Simon