From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104132 invoked by alias); 26 Oct 2015 17:39:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104122 invoked by uid 89); 26 Oct 2015 17:39:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 26 Oct 2015 17:39:18 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id F0BA52CD851; Mon, 26 Oct 2015 17:39:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9QHdFi9011083; Mon, 26 Oct 2015 13:39:16 -0400 Message-ID: <562E6543.7040509@redhat.com> Date: Tue, 27 Oct 2015 01:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi CC: gdb-patches@sourceware.org Subject: Re: [PATCH c++ 06/12] Fix constness problem in ioscm_make_gdb_stdio_port References: <1445831204-16588-1-git-send-email-simon.marchi@polymtl.ca> <1445831204-16588-6-git-send-email-simon.marchi@polymtl.ca> <562E5050.6010909@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00579.txt.bz2 On 10/26/2015 05:27 PM, Simon Marchi wrote: > On 26 October 2015 at 12:09, Pedro Alves wrote: >> WDYT? > > Sounds good to me. I wanted to avoid passing a string literal to > something that wasn't explicitely const (since if it tries to modify > the string, the program just crashes). But if we are sure that > scm_mode_bits does not do that, we can keep the simpler code. > > Here's a ready to push patch (not guaranteed to be well-formatted, > because gmail). > > > From ff3fa55ca1cf6bd23de87eb26687ad48fb2b3806 Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Mon, 26 Oct 2015 13:26:51 -0400 > Subject: [PATCH] guile: Simplify ioscm_make_gdb_stdio_port > > As pointed out by Pedro, it's clearer to do it this way. We can trust > that scm_mode_bits won't try to modify our string, even though it takes > a non-const char *. LGTM, though it's Doug's call. Thanks, Pedro Alves