From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by sourceware.org (Postfix) with ESMTPS id 5778D3857022 for ; Mon, 12 Apr 2021 11:43:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5778D3857022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f51.google.com with SMTP id w7-20020a1cdf070000b0290125f388fb34so6004242wmg.0 for ; Mon, 12 Apr 2021 04:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/53IqwnOJRueICVmqySMjYJg6E1t9r1iU2KLayo5Vco=; b=jdfcPsFUtHJ204M4r6YZX97ONa/C8aVjScm9EbD42AdPWSJem2nSKcAxArymmHIT6e rZg0f3WPVjtBnND6HXzxLJ4/hp+iXOB+UGNwtWFm2L/PIlUR80ibY9ZuRNRU+mhBMm3W 1Vsj7JYX/KF5DaihUE2QfVfIbYuvjNZyBw16QWD3iKXjLmih/ihwwJh39Q5sSKuQBTvl racTRl3A5aCrbjLyjQYJbtmnDijCqaXVsgW7+uOFpxV2DIin4lSnFy/wEiPENArAcBGL rmtncZvSRuXzNUje4GVyY9w+7pTaFK3isV4aKE61PGQLRa94bsNrR0PPdbmGRhdEK5qx QnUQ== X-Gm-Message-State: AOAM533emPZc+IIVTg7y8zXZo86rXy4MDFXoUQ66LtARR4xujxB8lKnq WF2Pq+zKqp/YhVM8YUL4d6vtR07eOAJdEg== X-Google-Smtp-Source: ABdhPJxwzBpddzPUyBOoGkuOOjdFOS/5R+DslamxfGiPuPowwUpV2t0PMg19ElI/SIcjz1l5qFbI0Q== X-Received: by 2002:a1c:4d19:: with SMTP id o25mr26376480wmh.137.1618227782794; Mon, 12 Apr 2021 04:43:02 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:6b6e:c7b6:c5a7:aac3? ([2001:8a0:f932:6a00:6b6e:c7b6:c5a7:aac3]) by smtp.gmail.com with ESMTPSA id o14sm15168819wrc.3.2021.04.12.04.43.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 04:43:01 -0700 (PDT) Subject: Re: [PATCH] gdb, gdbserver: remove WinCE support code From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210410231021.1232451-1-simon.marchi@polymtl.ca> Message-ID: <563cec09-990a-77f4-042f-2b95215e9829@palves.net> Date: Mon, 12 Apr 2021 12:42:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210410231021.1232451-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 11:43:06 -0000 On 11/04/21 00:10, Simon Marchi via Gdb-patches wrote: > The support for WinCE was removed with commit 84b300de3666 ("gdbserver: > remove support for ARM/WinCE"). There is some leftover code for WinCE > support, guarded by the _WIN32_WCE macro, which I didn't know of at the > time. > > I didn't remove the _WIN32_WCE references in the tests, because in > theory we still support the WinCE architecture in GDB (when debugging > remotely). So someone could run a test with that (although I'd be > really surprised). > > gdb/ChangeLog: > > * nat/windows-nat.c: Remove all code guarded by _WIN32_WCE. > * nat/windows-nat.h: Likewise. > > gdbserver/ChangeLog: > > * win32-low.cc: Remove all code guarded by _WIN32_WCE. > * win32-low.h: Likewise. OK. We can also get rid of the whole the_target->hostio_last_error / hostio-errno.cc / hostio_last_error_from_errno abstraction now. Thanks, Pedro Alves