From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] gdb/testsuite/gdb.trace: Deduplicate pcreg/spreg/fpreg.
Date: Tue, 10 Nov 2015 19:08:00 -0000 [thread overview]
Message-ID: <56424091.3090704@0x04.net> (raw)
In-Reply-To: <86twotwxgb.fsf@gmail.com>
On 10/11/15 18:55, Yao Qi wrote:
> Marcin KoÅcielnicki <koriakin@0x04.net> writes:
>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.trace/backtrace.exp: Use global fpreg/spreg definition, add $
>> in front.
>> * gdb.trace/change-loc.exp: Use global pcreg definition.
>> * gdb.trace/collection.exp: Use global pcreg/fpreg/spreg definition.
>> * gdb.trace/entry-values.exp: Use global spreg definition, add $
>> in front.
>> * gdb.trace/mi-trace-frame-collected.exp: Use global pcreg definition.
>> * gdb.trace/pending.exp: Likewise.
>> * gdb.trace/report.exp: Use global pcreg/fpreg/spreg definition.
>> * gdb.trace/trace-break.exp: Likewise.
>> * gdb.trace/trace-condition.exp: Use global pcreg definition, add $
>> in front.
>> * gdb.trace/unavailable.exp: Use global pcreg/fpreg/spreg definition.
>> * gdb.trace/while-dyn.exp: Use global fpreg definition, add $
>> in front.
>> * lib/trace-support.exp: Define fpreg, spreg, pcreg variables.
>
> Looks good to me. Thanks.
>
Thanks, pushed. Any feedback on the second patch?
prev parent reply other threads:[~2015-11-10 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 11:21 [PATCH " Marcin Kościelnicki
2015-11-10 11:21 ` [PATCH 2/2] gdb/testsuite/gdb.trace: Deduplicate set_point assembly Marcin Kościelnicki
2015-11-11 8:42 ` Yao Qi
2015-11-11 12:42 ` Marcin Kościelnicki
2015-11-10 11:35 ` [PATCH v2 1/2] gdb/testsuite/gdb.trace: Deduplicate pcreg/spreg/fpreg Marcin Kościelnicki
2015-11-10 17:55 ` Yao Qi
2015-11-10 19:08 ` Marcin Kościelnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56424091.3090704@0x04.net \
--to=koriakin@0x04.net \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).