From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [pushed/ob] Constify value_cstring
Date: Wed, 18 Nov 2015 16:21:00 -0000 [thread overview]
Message-ID: <564CA588.3030308@ericsson.com> (raw)
In-Reply-To: <1447862472-3721-1-git-send-email-palves@redhat.com>
On 15-11-18 11:01 AM, Pedro Alves wrote:
> From: Simon Marchi <simon.marchi@ericsson.com>
>
> gdb/ChangeLog:
> 2015-11-18 Simon Marchi <simon.marchi@ericsson.com>
>
> * valops.c (value_cstring): Constify 'ptr' parameter.
> * value.h (value_cstring): Constify 'ptr' parameter.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/valops.c | 2 +-
> gdb/value.h | 2 +-
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index a7b44fe..32f8134 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2015-11-18 Simon Marchi <simon.marchi@ericsson.com>
> +
> + * valops.c (value_cstring): Constify 'ptr' parameter.
> + * value.h (value_cstring): Constify 'ptr' parameter.
> +
> 2015-11-18 Yao Qi <yao.qi@linaro.org>
>
> * aarch64-tdep.c (pass_in_v): Add argument len. Add local array
> diff --git a/gdb/valops.c b/gdb/valops.c
> index 1e372ef..67e6afe 100644
> --- a/gdb/valops.c
> +++ b/gdb/valops.c
> @@ -1626,7 +1626,7 @@ value_array (int lowbound, int highbound, struct value **elemvec)
> }
>
> struct value *
> -value_cstring (char *ptr, ssize_t len, struct type *char_type)
> +value_cstring (const char *ptr, ssize_t len, struct type *char_type)
> {
> struct value *val;
> int lowbound = current_language->string_lower_bound;
> diff --git a/gdb/value.h b/gdb/value.h
> index 0a4bc47..94a2234 100644
> --- a/gdb/value.h
> +++ b/gdb/value.h
> @@ -696,7 +696,7 @@ extern struct value *value_mark (void);
>
> extern void value_free_to_mark (struct value *mark);
>
> -extern struct value *value_cstring (char *ptr, ssize_t len,
> +extern struct value *value_cstring (const char *ptr, ssize_t len,
> struct type *char_type);
> extern struct value *value_string (char *ptr, ssize_t len,
> struct type *char_type);
>
I pushed this one as well...
From 7cc3f8e23b5c19a50722adefce986230b191e9cd Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Wed, 18 Nov 2015 11:20:22 -0500
Subject: [PATCH] Constify value_string
If we constify value_cstring, we might as well constify this one.
gdb/ChangeLog:
* valops.c (value_string): Constify 'ptr' parameter.
* value.h (value_string): Constify 'ptr' parameter.
---
gdb/ChangeLog | 5 +++++
gdb/valops.c | 2 +-
gdb/value.h | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d92ba43..d1b40b8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,4 +1,9 @@
2015-11-18 Simon Marchi <simon.marchi@ericsson.com>
+
+ * valops.c (value_string): Constify 'ptr' parameter.
+ * value.h (value_string): Constify 'ptr' parameter.
+
+2015-11-18 Simon Marchi <simon.marchi@ericsson.com>
Pedro Alves <palves@redhat.com>
* break-catch-sig.c (signal_catchpoint_print_one): Add cast.
diff --git a/gdb/valops.c b/gdb/valops.c
index 67e6afe..5e5f685 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1649,7 +1649,7 @@ value_cstring (const char *ptr, ssize_t len, struct type *char_type)
string may contain embedded null bytes. */
struct value *
-value_string (char *ptr, ssize_t len, struct type *char_type)
+value_string (const char *ptr, ssize_t len, struct type *char_type)
{
struct value *val;
int lowbound = current_language->string_lower_bound;
diff --git a/gdb/value.h b/gdb/value.h
index 94a2234..eea0e59 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -698,7 +698,7 @@ extern void value_free_to_mark (struct value *mark);
extern struct value *value_cstring (const char *ptr, ssize_t len,
struct type *char_type);
-extern struct value *value_string (char *ptr, ssize_t len,
+extern struct value *value_string (const char *ptr, ssize_t len,
struct type *char_type);
extern struct value *value_array (int lowbound, int highbound,
--
2.5.1
next prev parent reply other threads:[~2015-11-18 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 16:01 Pedro Alves
2015-11-18 16:21 ` Simon Marchi [this message]
2015-11-18 16:41 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CA588.3030308@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).