From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126858 invoked by alias); 18 Nov 2015 17:44:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126742 invoked by uid 89); 18 Nov 2015 17:44:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f43.google.com Received: from mail-pa0-f43.google.com (HELO mail-pa0-f43.google.com) (209.85.220.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 18 Nov 2015 17:44:19 +0000 Received: by padhx2 with SMTP id hx2so51358318pad.1 for ; Wed, 18 Nov 2015 09:44:17 -0800 (PST) X-Received: by 10.66.224.165 with SMTP id rd5mr3783552pac.73.1447868657091; Wed, 18 Nov 2015 09:44:17 -0800 (PST) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id so4sm5447903pbc.72.2015.11.18.09.44.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2015 09:44:16 -0800 (PST) Subject: Re: [PATCH 0/6] [C++] Drop -fpermissive hack, enable -Werror To: Pedro Alves , gdb-patches@sourceware.org References: <1447864802-24016-1-git-send-email-palves@redhat.com> Cc: Simon Marchi From: Yao Qi Message-ID: <564CB8EC.5000203@gmail.com> Date: Wed, 18 Nov 2015 17:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447864802-24016-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00374.txt.bz2 On 18/11/15 16:39, Pedro Alves wrote: > The first 4 patches finally make GDB build cleanly in C++, at least on > x86_64 GNU/Linux and x86_64 mingw. At this point, I think we should > drop the -fpermissive hack and default to -Werror in C++ mode too, > which is what the last two patches do. Yeah! Good to see the switch to C++ will happen soon. Thanks, Pedro and Simon. > > This lets the buildbot catch C++ build regressions promptly -- we > already have a Fedora buildslave building in C++ mode specifically for > that, but it currently misses regressions around pointer casts and > enum conversions exactly due to -fpermissive/-Wno-error. > > Other ports still need further C++ conversion work, though the build > failures shouldn't be too many and should be mostly localized to > host/target-specific code. I don't have objections to this patch set, just want to know what is your plan to commit it. I'll fix C++ warnings and errors in ARM and AArch64 code. -- Yao (齐尧)