From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 13855384F494 for ; Wed, 14 Dec 2022 19:51:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 13855384F494 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A6F3E1E0CD; Wed, 14 Dec 2022 14:51:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1671047504; bh=agMz0FigAARFAAPC7HKb3foyjGlwCANkwlXBmU8Kayw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=tKIPwjqdhN3rjbQF7jhKd4KBibogro9SdqCSqD+raYW7xc5iC9S61Bq0VYVpnW5um PoOQjr71CPrg5mFb4CcSmCQUgQUjexihRs3rTu3vAEdQ6lC/cTjIWrt3NA5dfF9Qcl kL6hfQY/uNRzuXEI79GS3jgaeS2qPQhZFeqrcRAQ= Message-ID: <5652cff7-6fc3-82cb-091b-7a3d166c7a1b@simark.ca> Date: Wed, 14 Dec 2022 14:51:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/2] Move streq and compare_cstrings to gdbsupport Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20221214194606.4141035-1-tromey@adacore.com> <20221214194606.4141035-3-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20221214194606.4141035-3-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h > index 8a9448a638b..7f5ec584a2e 100644 > --- a/gdbsupport/common-utils.h > +++ b/gdbsupport/common-utils.h > @@ -93,6 +93,22 @@ startswith (gdb::string_view string, gdb::string_view pattern) > && strncmp (string.data (), pattern.data (), pattern.length ()) == 0); > } > > +/* Return true if the strings are equal. */ > + > +static inline bool > +streq (const char *lhs, const char *rhs) > +{ > + return !strcmp (lhs, rhs); > +} While at it, you could maybe change it to return strcmp (lhs, rhs) == 0; to make it follow our code convention. Otherwise, both patches LGTM: Approved-By: Simon Marchi Simon