From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6840 invoked by alias); 26 Nov 2015 09:43:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6823 invoked by uid 89); 26 Nov 2015 09:43:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Nov 2015 09:42:59 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id BA1D212BBE; Thu, 26 Nov 2015 09:42:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQ9gvZU009589; Thu, 26 Nov 2015 04:42:57 -0500 Message-ID: <5656D421.5010505@redhat.com> Date: Thu, 26 Nov 2015 09:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Metzger, Markus T" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] btrace: diagnose "record btrace pt" without libipt References: <1448011026-4192-1-git-send-email-markus.t.metzger@intel.com> <564F0591.3020006@redhat.com> <564F1C3D.1040709@redhat.com> <5655E3F6.3070002@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00539.txt.bz2 On 11/26/2015 07:12 AM, Metzger, Markus T wrote: > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Wednesday, November 25, 2015 5:38 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH] btrace: diagnose "record btrace pt" without libipt > > >> It would be nice if GDB could detect that record btrace is already >> enabled and push the record-btrace target automatically. I guess this >> requires some indication about the record status from gdbserver. Is >> there some other target that does this automatic push on (re-)connect that I could use as reference? > > E.g., linux-thread-db.c pushes itself from a new_objfile observer (thread_db_new_objfile), and the spu multiarch target pushes itself from an inferior_created observer (spu_multiarch_inferior_created). > > Thanks. I'll look into those examples. It'll take a bit but I don't think this is urgent. Certainly not urgent. > > > Are you OK to push the patch to avoid the internal error and handle the re-connect > case in a separate series? Yes. > > That patch might make sense for 7.10.1, as well. OK to push onto the 7.10 branch? OK. In that case, as per standard procedure, please file a PR and list it the 7.10 release wiki page. Thanks, Pedro Alves