From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113012 invoked by alias); 26 Nov 2015 12:38:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112926 invoked by uid 89); 26 Nov 2015 12:38:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Nov 2015 12:38:01 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 9C7A0DA3; Thu, 26 Nov 2015 12:37:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQCbw67011909; Thu, 26 Nov 2015 07:37:58 -0500 Message-ID: <5656FD25.9050607@redhat.com> Date: Thu, 26 Nov 2015 12:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] gdb: 'list' command, tweak handling of +/- arguments. References: <0af61eb3baed9334e8dc0aae2b572d87e2807fa8.1448411122.git.andrew.burgess@embecosm.com> In-Reply-To: <0af61eb3baed9334e8dc0aae2b572d87e2807fa8.1448411122.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00553.txt.bz2 On 11/25/2015 12:34 AM, Andrew Burgess wrote: > gdb/ChangeLog: > > * cli/cli-cmds.c (list_command): Check that the argument string is > a single character, either '+' or '-'. > > gdb/testsuite/ChangeLog: > > * gdb.base/list.exp (test_list_invalid_args): New function, > defined, and called. > + clean_restart ${binfile} > + gdb_test "list -INVALID" \ > + "invalid explicit location argument, \"-INVALID\"" \ > + "First use of \"list -INVALID\"" > + gdb_test "list -INVALID" \ > + "invalid explicit location argument, \"-INVALID\"" \ > + "Second use of \"list -INVALID\"" Nit: please use lowercase in test messages like mostly everywhere else (including this file). OK with that fixed. Thanks, Pedro Alves