From: Simon Marchi <simon.marchi@polymtl.ca>
To: Simon Marchi <simark@simark.ca>, Aaron Merey <amerey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: add set/show commands for managing debuginfod
Date: Tue, 2 Nov 2021 12:51:04 -0400 [thread overview]
Message-ID: <565fb0c8-7a80-f275-ede3-e5bc0ce9c960@polymtl.ca> (raw)
In-Reply-To: <fbe65ada-0f1f-87ff-52ac-6f2f5f1819dd@simark.ca>
On 2021-11-01 2:00 p.m., Simon Marchi wrote:
> On 2021-11-01 1:39 p.m., Aaron Merey wrote:
>> Hi Simon,
>>
>> On Mon, Nov 1, 2021 at 11:52 AM Simon Marchi <simark@simark.ca> wrote:
>>>
>>> On 2021-10-30 10:43 p.m., Simon Marchi via Gdb-patches wrote:
>>>> I'm considering fixing this for the index-cache (deprecating the old
>>>> commands, but keeping them as aliases of the new ones). If you agree, I
>>>> could do the same with "set debuginfo" too.
>>>>
>>>> Simon
>>>>
>>>
>>> I sent a patch series changing the index-cache commands here:
>>>
>>> https://sourceware.org/pipermail/gdb-patches/2021-November/182990.html
>>>
>>> Please let met know what you think.
>>
>> That patch set is definitely an improvement. I think you're right that
>> 'set/show debuginfod enabled on/off' is better than needing a
>> 'show debuginfod status' command that has no corresponding set
>> command. I also like that setting getters/setters now return scalars
>> by value.
>
> Ok, and sorry again for suggesting something and then changing my mind.
>
>>
>> Do you think we need to keep and deprecate the existing 'set
>> debuginfod on/off/ask' and 'show debuginfod status' commands?
>> Personally I'd rather just replace them considering how recently
>> they were added.
> No, since they were not part of a release.
>
> Simon
>
I have a WIP patch to adjust the debuginfod commands that I can post after
my series reworking the index-cache commands is merged (it depeneds on some
patches of that series).
Simon
next prev parent reply other threads:[~2021-11-02 16:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 23:01 [PATCH 0/2 v3] gdb: Add debuginfod first-use notification Aaron Merey
2021-10-18 23:01 ` [PATCH 1/2] gdb: add set/show commands for managing debuginfod Aaron Merey
2021-10-20 20:34 ` Keith Seitz
2021-10-21 22:23 ` Lancelot SIX
2021-10-25 22:30 ` Aaron Merey
2021-10-21 22:02 ` Lancelot SIX
2021-10-26 16:08 ` Simon Marchi
2021-10-28 22:18 ` Aaron Merey
2021-10-29 1:47 ` Simon Marchi
2021-10-30 1:09 ` Aaron Merey
2021-10-30 1:54 ` Simon Marchi
2021-10-31 2:43 ` Simon Marchi
2021-11-01 15:52 ` Simon Marchi
2021-11-01 17:39 ` Aaron Merey
2021-11-01 18:00 ` Simon Marchi
2021-11-02 16:51 ` Simon Marchi [this message]
2021-11-02 20:35 ` Aaron Merey
2021-10-18 23:01 ` [PATCH 2/2] gdb.texinfo: Expand documentation for debuginfod Aaron Merey
2021-10-19 11:17 ` Eli Zaretskii
2021-10-19 22:35 ` Aaron Merey
2021-10-20 11:38 ` Eli Zaretskii
2021-10-30 1:18 ` Aaron Merey
2021-10-30 6:57 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565fb0c8-7a80-f275-ede3-e5bc0ce9c960@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).