From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33397 invoked by alias); 5 Dec 2015 02:14:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33278 invoked by uid 89); 5 Dec 2015 02:14:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 05 Dec 2015 02:14:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id AFB478E694; Sat, 5 Dec 2015 02:14:55 +0000 (UTC) Received: from [10.3.113.46] (ovpn-113-46.phx2.redhat.com [10.3.113.46]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB52EseM024818; Fri, 4 Dec 2015 21:14:54 -0500 Subject: Re: [PATCH v3 1/2] gdbserver: set ptrace flags after creating inferiors To: Pedro Alves , gdb-patches@sourceware.org References: <1448506425-24691-1-git-send-email-jistone@redhat.com> <1449196006-13759-1-git-send-email-jistone@redhat.com> <5661840D.5090203@redhat.com> Cc: philippe.waroquiers@skynet.be, sergiodj@redhat.com, eliz@gnu.org, xdje42@gmail.com From: Josh Stone Message-ID: <5662489E.6070708@redhat.com> Date: Sat, 05 Dec 2015 02:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5661840D.5090203@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00098.txt.bz2 On 12/04/2015 04:16 AM, Pedro Alves wrote: > Hi Josh, > > Thanks for the update, and thanks for the new test. > > On 12/04/2015 02:26 AM, Josh Stone wrote: > >> 2015-12-03 Josh Stone >> >> * gdb.base/catch-static-fork.exp: New. > > Nit, to me, "catch-fork-static.exp" would be more natural. > As it reads as something about either "catch static" or > about a "static fork". Sure, I'll rename it. >> +gdb_test "run" "Catchpoint \[0-9\]* \\(forked process \[0-9\]*\\),.*" \ >> + "run to fork" >> > > Please avoid hardcoding the "run" command: > > gdb_run_cmd > gdb_test "" \ > "Catchpoint \[0-9\]* \\(forked process \[0-9\]*\\),.*" \ > "run to fork" > > Even though "catch fork" currently doesn't work with plain > "target remote", which doesn't do "run", there are patches pending > to make it work. With this change, this test should then work > with --target_board=native-gdbserver too. Great, I'll make this change too. > OK with that change. Thanks, I'll push it out with those tweaks.