From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32077 invoked by alias); 7 Dec 2015 14:49:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31365 invoked by uid 89); 7 Dec 2015 14:49:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Dec 2015 14:49:55 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 08.75.32102.C8C95665; Mon, 7 Dec 2015 15:49:49 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.248.2; Mon, 7 Dec 2015 09:49:52 -0500 Subject: Re: [PATCH v6 4/7] Share regcache function regcache_raw_read_unsigned. To: References: <1449254773-19019-1-git-send-email-antoine.tremblay@ericsson.com> <1449254773-19019-5-git-send-email-antoine.tremblay@ericsson.com> <86bna2s4ok.fsf@gmail.com> From: Antoine Tremblay Message-ID: <56659C90.7040109@ericsson.com> Date: Mon, 07 Dec 2015 14:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <86bna2s4ok.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00133.txt.bz2 On 12/07/2015 09:40 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> gdb/ChangeLog: >> * Makefile.in: Add common-regcache.c/.o. > > Need to describe what do we change in Makefile.in, like > > * Makefile.in (SFILES): Append common/common-regcache.c. > (COMMON_OBS): Append common/common-regcache.o. > (common-regcache.o): New rule. > OK, done. >> * common/common-regcache.h (register_status) New enum. >> (regcache_raw_read_unsigned): New declaration. >> * common/common-regcache.c: New file. >> * regcache.h (enum register_status): Move to common-regcache.h. >> (regcache_raw_read_unsigned): Likewise. >> (regcache_raw_get_unsigned): Likewise. >> >> gdb/gdbserver/ChangeLog: >> >> * Makefile.in: Add common-regcache.c/.o. > > Likewise. > >> * regcache.c (init_register_cache): Initialize cache to >> REG_UNAVAILABLE. >> (regcache_raw_read_unsigned): New function. >> * regcache.h (REG_UNAVAILABLE, REG_VALID): Replaced by shared >> register_status enum. > > Patch is good to me, otherwise. >