From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v7.1] Support software single step on ARM in GDBServer.
Date: Fri, 11 Dec 2015 13:36:00 -0000 [thread overview]
Message-ID: <566AD173.2060509@ericsson.com> (raw)
In-Reply-To: <867fklqflh.fsf@gmail.com>
On 12/11/2015 08:28 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> * linux-aarch32-low.c (arm_abi_breakpoint): Remove macro. Moved
>> to linux-aarch32-low.c.
>> (arm_eabi_breakpoint, arm_breakpoint): Likewise.
>> (arm_breakpoint_len, thumb_breakpoint): Likewise.
>> (thumb_breakpoint_len, thumb2_breakpoint): Likewise.
>> (thumb2_breakpoint_len): Likewise.
>
> I don't see how are they used outside of linux-aarch32-low.c, so why do
> you move them out to linux-aarch32-low.h?
>
That's true, I guess I was used to breakpoint functions in linux-arm-low.c.
Fixing this now.
Thanks,
Antoine
next prev parent reply other threads:[~2015-12-11 13:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 14:07 [PATCH v7 0/8] Support software single step and conditional breakpoints " Antoine Tremblay
2015-12-08 14:07 ` [PATCH v7 2/8] Share some ARM target dependent code from GDB with GDBServer Antoine Tremblay
2015-12-08 14:07 ` [PATCH v7 5/8] Share regcache function regcache_raw_read_unsigned Antoine Tremblay
2015-12-08 14:07 ` [PATCH v7 1/8] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer Antoine Tremblay
2015-12-08 14:07 ` [PATCH v7 4/8] Refactor arm_software_single_step to use regcache Antoine Tremblay
2015-12-11 11:37 ` Yao Qi
2015-12-11 12:41 ` Antoine Tremblay
2015-12-08 14:07 ` [PATCH v7 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr Antoine Tremblay
2015-12-11 11:29 ` Yao Qi
2015-12-11 11:59 ` Pedro Alves
2015-12-11 12:02 ` Yao Qi
2015-12-11 12:05 ` Pedro Alves
2015-12-11 12:31 ` Antoine Tremblay
2015-12-11 12:47 ` Pedro Alves
2015-12-11 13:04 ` Antoine Tremblay
2015-12-11 13:20 ` Pedro Alves
2015-12-11 13:25 ` Antoine Tremblay
2015-12-15 12:46 ` Antoine Tremblay
2015-12-16 15:59 ` Pedro Alves
2015-12-16 16:36 ` Yao Qi
2015-12-16 16:37 ` Antoine Tremblay
2015-12-11 12:29 ` Antoine Tremblay
2015-12-16 15:59 ` Pedro Alves
2015-12-16 16:05 ` Antoine Tremblay
2015-12-16 16:24 ` [PATCH v7.1 " Antoine Tremblay
2015-12-17 10:09 ` Yao Qi
2015-12-17 10:17 ` Pedro Alves
2015-12-17 12:51 ` Antoine Tremblay
2015-12-17 13:25 ` Yao Qi
2015-12-17 13:36 ` Antoine Tremblay
2015-12-08 14:08 ` [PATCH v7 7/8] Enable software single stepping for while-stepping actions in GDBServer Antoine Tremblay
2015-12-08 14:08 ` [PATCH v7 6/8] Support software single step on ARM " Antoine Tremblay
2015-12-09 20:09 ` [PATCH v7.1] " Antoine Tremblay
2015-12-11 13:28 ` Yao Qi
2015-12-11 13:36 ` Antoine Tremblay [this message]
2015-12-11 13:41 ` Antoine Tremblay
2015-12-11 14:45 ` Yao Qi
2015-12-11 14:43 ` Yao Qi
2015-12-11 15:06 ` Antoine Tremblay
2015-12-11 15:26 ` Antoine Tremblay
2015-12-11 15:38 ` Yao Qi
2015-12-11 16:11 ` Antoine Tremblay
2015-12-11 16:26 ` [PATCH v7.2] " Antoine Tremblay
2015-12-11 17:28 ` Yao Qi
2015-12-11 17:52 ` Antoine Tremblay
2015-12-08 14:08 ` [PATCH v7 8/8] Enable conditional breakpoints for targets that support software single step " Antoine Tremblay
2015-12-10 15:59 ` [PATCH v7 0/8] Support software single step and conditional breakpoints on ARM " Yao Qi
2015-12-10 16:02 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566AD173.2060509@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).