From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59157 invoked by alias); 15 Dec 2015 12:46:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59148 invoked by uid 89); 15 Dec 2015 12:46:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Dec 2015 12:46:09 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 4D.C7.32102.88B00765; Tue, 15 Dec 2015 13:46:00 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Tue, 15 Dec 2015 07:46:05 -0500 Subject: Re: [PATCH v7 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr. To: Yao Qi References: <1449583641-18156-1-git-send-email-antoine.tremblay@ericsson.com> <1449583641-18156-4-git-send-email-antoine.tremblay@ericsson.com> <86io45ql3x.fsf@gmail.com> <566ABA91.5000508@redhat.com> <566ABB44.3080004@gmail.com> <566ABC0C.10101@redhat.com> <566AC23B.6060800@ericsson.com> CC: , Pedro Alves From: Antoine Tremblay Message-ID: <56700B8D.2090302@ericsson.com> Date: Tue, 15 Dec 2015 12:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <566AC23B.6060800@ericsson.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00287.txt.bz2 On 12/11/2015 07:31 AM, Antoine Tremblay wrote: > > > On 12/11/2015 07:05 AM, Pedro Alves wrote: >> On 12/11/2015 12:02 PM, Yao Qi wrote: >>> On 11/12/15 11:59, Pedro Alves wrote: >>>> but then you might as well just do: >>>> >>>> #define ARM_SIGRETURN 119 >>> >>> How about using __NR_sigreturn and __NR_rt_sigreturn directly? like >>> what patch #6 does. >> >> Those are host/native macros. Only make sense for the running host. >> Can't use that in a tdep file, like arm-linux-tdep.c. Otherwise, e.g., >> a x86-hosted cross debugger would be using the x86 __NR_sigreturn, etc. >> > > Exactly that's why I use those only in GDBServer. > > Personally while I like the #define ARM_SIGRETURN 119 better, I think > the xml function is fine. Any news about this one ? Given that I use xml in GDB and __NR_sigreturn macros in GDBServer... Is the patch OK ? Thanks, Antoine