From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69912 invoked by alias); 18 Dec 2015 16:45:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69897 invoked by uid 89); 18 Dec 2015 16:45:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=highlighted, prepares X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 18 Dec 2015 16:45:55 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 26.B6.06940.D5734765; Fri, 18 Dec 2015 17:42:06 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Fri, 18 Dec 2015 11:45:52 -0500 Subject: Re: [PATCH v8 0/7] Support software single step and conditional breakpoints on ARM in GDBServer. To: References: <1450361684-29536-1-git-send-email-antoine.tremblay@ericsson.com> From: Antoine Tremblay Message-ID: <56743840.1030903@ericsson.com> Date: Fri, 18 Dec 2015 16:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450361684-29536-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00368.txt.bz2 On 12/17/2015 09:14 AM, Antoine Tremblay wrote: > In this v8: > > * Remove old patch 3. > * Patch 3: Use #define ARM_SIGRETURN, ARM_RT_SIGRETURN > * Other small style fixes highlighted in v7. > > Patch 1: is OK. > Patch 2: is OK. > Patch 3: Needs review ? > Patch 4: is OK. > Patch 5: is OK> > Patch 6: is OK. > Patch 7: is OK. > > --- > > This patch series adds support for software single step and conditional > breakpoints on ARM in GDBServer. > > Patches 1,2,3,4 prepares for sharing of software single step code for ARM in > GDB with GDBServer. > > Patch 5 Implements the support for ARM software single step. > > Patch 6 Adds support for while-stepping actions. > > Patch 7 Adds support for conditional breakpoints in GDBServer. > > This patch set has no observed regressions, tested on Ubuntu 14.04 ARMv7 > and x86. With gdbserver-{native,extended} / { -marm -mthumb } > > Note also that while I could not test thumbv1 instructions directly with > gcc -marmv4t, manual testing of the software single step was done for > thumv1 instructions. > This is now pushed in. Thanks to Yao and Pedro for all the reviews!! Happy holidays! Regards, Antoine