From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52272 invoked by alias); 30 Dec 2015 19:17:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52262 invoked by uid 89); 30 Dec 2015 19:17:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:demangl, 20151220, 2015-12-20, maintained X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Dec 2015 19:17:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2A0108CB55; Wed, 30 Dec 2015 19:17:02 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBUJH0ra011631; Wed, 30 Dec 2015 14:17:01 -0500 Message-ID: <56842DAC.7060400@redhat.com> Date: Wed, 30 Dec 2015 19:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Artemiy Volkov , gdb-patches@sourceware.org Subject: Re: [PATCH 05/11] [PR gdb/14441] gdb: demangle: implement demangling for rvalue reference typenames References: <1450661481-31178-1-git-send-email-artemiyv@acm.org> <1450661481-31178-6-git-send-email-artemiyv@acm.org> In-Reply-To: <1450661481-31178-6-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00537.txt.bz2 Hi Artemiy, Thanks much for working on this. Just a quick note below. On 12/21/2015 01:31 AM, Artemiy Volkov wrote: > libiberty/ChangeLog: > > 2015-12-20 Artemiy Volkov > > * cplus-dem.c (enum type_kind_t): Add tk_rvalue_reference > constant. > (demangle_template_value_parm): Handle tk_rvalue_reference > type kind. > (do_type): Support 'O' type id (rvalue references). It'd be nice to have a few tests in libiberty/testsuite/ to cover this. Note that libiberty is maintained by gcc. You need to send this to the gcc-patches list. Once it is approved upstream, we can merge it. Thanks, Pedro Alves