From: Pedro Alves <pedro@palves.net>
To: Tom de Vries <tdevries@suse.de>,
Simon Marchi <simon.marchi@polymtl.ca>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [gdb/build] Fix Wimplicit-exception-spec-mismatch in clang build
Date: Fri, 5 Nov 2021 17:07:30 +0000 [thread overview]
Message-ID: <5684dfa8-572d-f21c-c3dd-a9610d036f06@palves.net> (raw)
In-Reply-To: <915b1bef-6553-dddc-e274-384e49607dbb@suse.de>
On 2021-11-05 10:03, Tom de Vries via Gdb-patches wrote:
>
> +extern void
> +operator delete (void *p, std::size_t) noexcept;
The convention is to not format declarations with function name at column 0. So here:
extern void operator delete (void *p, std::size_t) noexcept;
> +
> void
> operator delete (void *p, std::size_t) noexcept
> {
> return ::operator delete (p, std::nothrow);
> }
>
> +extern void operator delete[] (void *p) noexcept;
> +
... like you did here.
I suggest a comment mentioning the need to declare these if compiling in C++11.
next prev parent reply other threads:[~2021-11-05 17:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 20:34 [PATCH] gdb/testsuite: set ASAN_OPTIONS=detect_leaks=0 while running tests Simon Marchi
2021-11-03 10:24 ` Tom de Vries
2021-11-03 12:28 ` Tom de Vries
2021-11-03 14:45 ` Simon Marchi
2021-11-04 11:55 ` Tom de Vries
2021-11-04 20:04 ` Simon Marchi
2021-11-05 10:03 ` [gdb/build] Fix Wimplicit-exception-spec-mismatch in clang build Tom de Vries
2021-11-05 14:24 ` Simon Marchi
2021-11-05 17:00 ` Pedro Alves
2021-11-05 17:07 ` Pedro Alves [this message]
2021-11-10 13:32 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5684dfa8-572d-f21c-c3dd-a9610d036f06@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).