From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v8 5/7] Support software single step on ARM in GDBServer
Date: Mon, 04 Jan 2016 12:59:00 -0000 [thread overview]
Message-ID: <568A6C91.9080307@ericsson.com> (raw)
In-Reply-To: <86bn9jewec.fsf@gmail.com>
On 12/21/2015 08:58 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> -#if (defined __ARM_EABI__ || defined __aarch64__)
>> -static const unsigned long arm_breakpoint = arm_eabi_breakpoint;
>> -#else
>> -static const unsigned long arm_breakpoint = arm_abi_breakpoint;
>> -#endif
>> -
>
>> +
>> +#ifndef __ARM_EABI__
>> +static const unsigned long arm_breakpoint = arm_abi_breakpoint;
>> +#else
>> +static const unsigned long arm_breakpoint = arm_eabi_breakpoint;
>> +#endif
>
> Your code move actually changes the code. My recent fix
> https://sourceware.org/ml/gdb-patches/2015-12/msg00215.html was removed
> by mistake. This breaks the whole aarch64 multi-arch debugging.
>
> I'll push the patch below in.
>
Sorry about that, thanks for the fix!
Antoine
next prev parent reply other threads:[~2016-01-04 12:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 14:14 [PATCH v8 0/7] Support software single step and conditional breakpoints " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 4/7] Share regcache function regcache_raw_read_unsigned Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 3/7] Refactor arm_software_single_step to use regcache Antoine Tremblay
2016-01-18 10:35 ` Yao Qi
2016-01-18 13:07 ` Yao Qi
2016-01-18 14:02 ` Antoine Tremblay
2016-01-21 7:52 ` Yao Qi
2015-12-17 14:15 ` [PATCH v8 6/7] Enable software single stepping for while-stepping actions in GDBServer Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 2/7] Share some ARM target dependent code from GDB with GDBServer Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 5/7] Support software single step on ARM in GDBServer Antoine Tremblay
2015-12-21 13:58 ` Yao Qi
2016-01-04 12:59 ` Antoine Tremblay [this message]
2016-01-06 14:23 ` Yao Qi
2016-01-06 14:36 ` Antoine Tremblay
2016-01-06 14:56 ` Yao Qi
2016-01-06 14:58 ` Antoine Tremblay
2016-01-06 14:42 ` Yao Qi
2016-01-06 14:50 ` Antoine Tremblay
2016-01-06 15:04 ` Yao Qi
2016-01-13 16:13 ` Yao Qi
2016-01-13 19:10 ` Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 1/7] Replace breakpoint_reinsert_addr by get_next_pcs operation " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 7/7] Enable conditional breakpoints for targets that support software single step " Antoine Tremblay
2015-12-18 12:56 ` [PATCH v8 0/7] Support software single step and conditional breakpoints on ARM " Antoine Tremblay
2015-12-18 16:45 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568A6C91.9080307@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).