From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73028 invoked by alias); 4 Jan 2016 12:59:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73018 invoked by uid 89); 4 Jan 2016 12:59:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*Ad:D*ericsson.com, Antoine, antoine, D*ericsson.com X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 04 Jan 2016 12:59:01 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 85.05.06940.EDA6A865; Mon, 4 Jan 2016 13:51:42 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Mon, 4 Jan 2016 07:58:57 -0500 Subject: Re: [PATCH v8 5/7] Support software single step on ARM in GDBServer To: Yao Qi References: <1450361684-29536-1-git-send-email-antoine.tremblay@ericsson.com> <1450361684-29536-6-git-send-email-antoine.tremblay@ericsson.com> <86bn9jewec.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <568A6C91.9080307@ericsson.com> Date: Mon, 04 Jan 2016 12:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <86bn9jewec.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00034.txt.bz2 On 12/21/2015 08:58 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> -#if (defined __ARM_EABI__ || defined __aarch64__) >> -static const unsigned long arm_breakpoint = arm_eabi_breakpoint; >> -#else >> -static const unsigned long arm_breakpoint = arm_abi_breakpoint; >> -#endif >> - > >> + >> +#ifndef __ARM_EABI__ >> +static const unsigned long arm_breakpoint = arm_abi_breakpoint; >> +#else >> +static const unsigned long arm_breakpoint = arm_eabi_breakpoint; >> +#endif > > Your code move actually changes the code. My recent fix > https://sourceware.org/ml/gdb-patches/2015-12/msg00215.html was removed > by mistake. This breaks the whole aarch64 multi-arch debugging. > > I'll push the patch below in. > Sorry about that, thanks for the fix! Antoine