From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v8 5/7] Support software single step on ARM in GDBServer
Date: Wed, 06 Jan 2016 14:36:00 -0000 [thread overview]
Message-ID: <568D2659.20603@ericsson.com> (raw)
In-Reply-To: <86a8oiyegx.fsf@gmail.com>
On 01/06/2016 09:22 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
> Hi Antoine,
>
>> --- a/gdb/gdbserver/linux-aarch32-low.h
>> +++ b/gdb/gdbserver/linux-aarch32-low.h
>> @@ -15,6 +15,27 @@
>> You should have received a copy of the GNU General Public License
>> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>>
>> +/* Correct in either endianness. */
>> +#define arm_abi_breakpoint 0xef9f0001UL
>> +
>> +/* For new EABI binaries. We recognize it regardless of which ABI
>> + is used for gdbserver, so single threaded debugging should work
>> + OK, but for multi-threaded debugging we only insert the current
>> + ABI's breakpoint instruction. For now at least. */
>> +#define arm_eabi_breakpoint 0xe7f001f0UL
>> +
>> +#ifndef __ARM_EABI__
>> +static const unsigned long arm_breakpoint = arm_abi_breakpoint;
>> +#else
>> +static const unsigned long arm_breakpoint = arm_eabi_breakpoint;
>> +#endif
>> +
>> +#define arm_breakpoint_len 4
>> +static const unsigned short thumb_breakpoint = 0xde01;
>> +#define thumb_breakpoint_len 2
>> +static const unsigned short thumb2_breakpoint[] = { 0xf7f0, 0xa000 };
>> +#define thumb2_breakpoint_len 4
>> +
>
> This change causes GDBserver build errors on both ARM and AArch64, which
> are shown in the commit log of the patch below.
>
Strange I did not see those at all with arm-linux-gnueabihf-gcc
(Ubuntu/Linaro 4.8.2-16ubuntu4) 4.8.2
Ideas on why you see those and I would not ?
Looking forward to your follow up patches about the issues revealed...
Thanks,
Antoine
next prev parent reply other threads:[~2016-01-06 14:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 14:14 [PATCH v8 0/7] Support software single step and conditional breakpoints " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 7/7] Enable conditional breakpoints for targets that support software single step " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 2/7] Share some ARM target dependent code from GDB with GDBServer Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 5/7] Support software single step on ARM in GDBServer Antoine Tremblay
2015-12-21 13:58 ` Yao Qi
2016-01-04 12:59 ` Antoine Tremblay
2016-01-06 14:23 ` Yao Qi
2016-01-06 14:36 ` Antoine Tremblay [this message]
2016-01-06 14:56 ` Yao Qi
2016-01-06 14:58 ` Antoine Tremblay
2016-01-06 14:42 ` Yao Qi
2016-01-06 14:50 ` Antoine Tremblay
2016-01-06 15:04 ` Yao Qi
2016-01-13 16:13 ` Yao Qi
2016-01-13 19:10 ` Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 1/7] Replace breakpoint_reinsert_addr by get_next_pcs operation " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 6/7] Enable software single stepping for while-stepping actions " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 3/7] Refactor arm_software_single_step to use regcache Antoine Tremblay
2016-01-18 10:35 ` Yao Qi
2016-01-18 13:07 ` Yao Qi
2016-01-18 14:02 ` Antoine Tremblay
2016-01-21 7:52 ` Yao Qi
2015-12-17 14:15 ` [PATCH v8 4/7] Share regcache function regcache_raw_read_unsigned Antoine Tremblay
2015-12-18 12:56 ` [PATCH v8 0/7] Support software single step and conditional breakpoints on ARM in GDBServer Antoine Tremblay
2015-12-18 16:45 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568D2659.20603@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).