From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21323 invoked by alias); 7 Jan 2016 22:24:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21256 invoked by uid 89); 7 Jan 2016 22:24:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=1.3 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Jan 2016 22:24:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id EF8D78E69C; Thu, 7 Jan 2016 22:24:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u07MORXO028065; Thu, 7 Jan 2016 17:24:28 -0500 Message-ID: <568EE59B.3050302@redhat.com> Date: Thu, 07 Jan 2016 22:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v3 4/7] Per-inferior/Inferior-qualified thread IDs References: <1452085418-18300-1-git-send-email-palves@redhat.com> <1452085418-18300-5-git-send-email-palves@redhat.com> <568EE054.7040508@ericsson.com> In-Reply-To: <568EE054.7040508@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00121.txt.bz2 On 01/07/2016 10:01 PM, Simon Marchi wrote: > Oh, one comment I forgot: > > On 16-01-06 08:03 AM, Pedro Alves wrote: >> + A range will be of the form >> + .- and will represent >> + all the threads of inferior inferior_num with number between >> + thread_number1 and thread_number2, inclusive. can >> + also be omitted, as in -, in which >> + case GDB infers the inferior number from the current inferior. > > Because this class^Wstruct and associated functions are disconnected from > the global GDB state (which is great), it would be more accurate to say > something like "from the default passed to the constructor^Winit function. Thanks for noticing that, I'll fix. The code used to rely on the global state when I wrote the comment, then forgot to update it. (While writing the tests I noticed that "info threads 1.1 2.1 3" would try to print thread 2.3 instead of 1.3 otherwise, because "info threads" switches context to each thread being printed, which meant that by the time we got to "3", the current inferior was 2, while the current inferior before the command was entered was 1.) Thanks, Pedro Alves