From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Always organize test artifacts in a directory hierarchy
Date: Tue, 12 Jan 2016 13:00:00 -0000 [thread overview]
Message-ID: <5694F8D2.5090807@redhat.com> (raw)
In-Reply-To: <1452268308-23845-1-git-send-email-simon.marchi@ericsson.com>
On 01/08/2016 03:51 PM, Simon Marchi wrote:
> When running tests in parallel, each test puts its generated files in a
> different directory, under "testsuite/outputs":
>
> outputs
> âââ gdb.base
> â âââ break
> â âââ whatis
> â âââ ...
> âââ gdb.python
> â âââ py-type
> â âââ py-value
> â âââ ...
> âââ ...
>
> I think it would be nice if it was always organized like this, even in
> serial mode, as it would isolate the test cases a bit more. An artifact
> created by a test wouldn't get overwritten by another test. It would be
> clear which test produced which files.
>
Yao posted a patch that moved sequential runs to a subdir as well:
https://sourceware.org/ml/gdb-patches/2014-12/msg00236.html
Though I think I too prefer making sequential/parallel the same.
You should cross check your patch with yours. For e.g., don't you
need to mkdir -p the outputs/ dir for the first time?
> It would also make it easier to clean up. Currently, make clean in the
> testsuite is broken. A lot of executables are left all over the place
> because their names do not appear in gdb.*/Makefile. If everything is
> in "outputs", then we just have to delete that directory (which we
> already do).
>
> At the same time it makes the gdb.foo directories and their Makefiles
> useless in the build directory, since they are pretty much only used for
> cleaning.
Yeah, I think we all agreed to this in the past.
>
> Note: the performance testsuite still produces some files in gdb.perf.
> If this is accepted, we can always look at that later.
Agreed.
>
> What do you think?
I like this.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-01-12 13:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 15:52 Simon Marchi
2016-01-12 13:00 ` Pedro Alves [this message]
[not found] ` <56952A6C.8070507@ericsson.com>
2016-01-13 11:11 ` Pedro Alves
2016-01-17 6:37 ` Joel Brobecker
2016-01-20 23:29 ` Simon Marchi
2016-01-25 21:24 ` Simon Marchi
2016-01-25 21:54 ` Simon Marchi
2016-02-01 22:41 ` Simon Marchi
2016-02-07 7:10 ` Joel Brobecker
2016-02-08 19:01 ` Simon Marchi
2016-02-08 19:26 ` Simon Marchi
2016-02-11 21:22 ` [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy] Jan Kratochvil
2016-02-12 18:34 ` Simon Marchi
2016-02-12 18:41 ` Pedro Alves
2016-02-12 18:56 ` Simon Marchi
2016-02-12 21:54 ` Simon Marchi
2016-02-12 23:01 ` Pedro Alves
2016-02-15 16:17 ` Simon Marchi
2016-02-12 18:47 ` Jan Kratochvil
2016-02-12 19:38 ` Simon Marchi
2016-02-15 17:58 ` [testsuite obv+7.11] Fix more testcases with standard_output_file [Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694F8D2.5090807@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).