From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85808 invoked by alias); 14 Jan 2016 15:34:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85797 invoked by uid 89); 14 Jan 2016 15:34:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:find_st, abort_iteration, stop_signal, non-exited X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Jan 2016 15:34:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 580288E398; Thu, 14 Jan 2016 15:34:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0EFYaeb003991; Thu, 14 Jan 2016 10:34:36 -0500 Message-ID: <5697C00C.3040109@redhat.com> Date: Thu, 14 Jan 2016 15:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: John Baldwin , gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/6] Dump register notes for each thread when generating a FreeBSD core. References: <1452721551-657-1-git-send-email-jhb@FreeBSD.org> <1452721551-657-7-git-send-email-jhb@FreeBSD.org> In-Reply-To: <1452721551-657-7-git-send-email-jhb@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00303.txt.bz2 [Dropping binutils.] On 01/13/2016 09:45 PM, John Baldwin wrote: > gdb/ChangeLog: > > * fbsd-tdep.c (find_stop_signal): Remove. > (struct fbsd_collect_regset_section_cb) : New field. > : New field. > : New field. > (fbsd_collect_regset_section_cb): Use new fields. > (fbsd_collect_thread_registers): New function. > (struct fbsd_corefile_thread_data): New structure. > (fbsd_corefile_thread): New function. > (fbsd_make_corefile_notes): Use new function to dump notes for each > non-exited thread in a process. LGTM. Thanks, Pedro Alves