public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/2] Star wildcard ranges (e.g., "info thread 2.*")
Date: Thu, 14 Jan 2016 16:52:00 -0000	[thread overview]
Message-ID: <5697D263.7060707@ericsson.com> (raw)
In-Reply-To: <1452702886-17749-1-git-send-email-palves@redhat.com>

On 16-01-13 11:34 AM, Pedro Alves wrote:
> This series adds support for specifying "all threads of inferior N",
> by writing "*" as thread number/range in thread ID lists.
> 
> E.g., "info threads 2.*" or "thread apply 2.* bt".
> 
> While doing this, I noticed a few bugs in "thread apply" (that even
> predate the per-inferior thread IDs series).  Patch 1 fixes them.  I'm
> only keeping both patches together to make it clear that patch 2
> applies on top of patch 1.
> 
> Pedro Alves (2):
>   Fix "thread apply $conv_var" and misc other related problems
>   Star wildcard ranges (e.g., "info thread 2.*")
> 
>  gdb/NEWS                         |   6 ++
>  gdb/cli/cli-utils.c              |  15 ++++
>  gdb/cli/cli-utils.h              |   8 +++
>  gdb/doc/gdb.texinfo              |  39 ++++++++---
>  gdb/testsuite/gdb.multi/tids.exp | 143 +++++++++++++++++++++++++++++++++++----
>  gdb/thread.c                     |  40 +++++++++--
>  gdb/tid-parse.c                  |  63 ++++++++++++++---
>  gdb/tid-parse.h                  |   7 ++
>  8 files changed, 285 insertions(+), 36 deletions(-)
> 

I took a look at those, it LGTM.  Thanks for the thorough tests.

Simon

  parent reply	other threads:[~2016-01-14 16:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 16:34 Pedro Alves
2016-01-13 16:34 ` Pedro Alves
2016-01-13 16:42   ` Pedro Alves
2016-01-13 16:34 ` [PATCH 1/2] Fix "thread apply $conv_var" and misc other related problems Pedro Alves
2016-01-13 16:34 ` [PATCH 2/2] Star wildcard ranges (e.g., "info thread 2.*") Pedro Alves
2016-01-13 17:00   ` Eli Zaretskii
2016-01-14 11:13     ` Pedro Alves
2016-01-14 16:16       ` Eli Zaretskii
2016-01-14 16:42         ` Pedro Alves
2016-01-14 11:29   ` Pedro Alves
2016-01-14 16:52 ` Simon Marchi [this message]
2016-01-15 21:50 ` [PATCH 0/2] " Pedro Alves
2016-01-14 11:39 Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5697D263.7060707@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).