From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5A36E385C41A for ; Mon, 23 Aug 2021 17:48:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A36E385C41A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17NHmOGn025813 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Aug 2021 13:48:28 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17NHmOGn025813 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EF8DA1E813; Mon, 23 Aug 2021 13:48:23 -0400 (EDT) Subject: Re: [PATCH] Replace deprecated_target_wait_hook by an observer To: Patrick Monnerat , gdb-patches@sourceware.org References: <20210822164256.144875-1-patrick@monnerat.net> <934649d9-1f4a-0b3c-a6de-5641c49bb0c6@monnerat.net> From: Simon Marchi Message-ID: <5697ed83-dd71-c977-9f04-cffa75751c23@polymtl.ca> Date: Mon, 23 Aug 2021 13:48:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <934649d9-1f4a-0b3c-a6de-5641c49bb0c6@monnerat.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 23 Aug 2021 17:48:24 +0000 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2021 17:48:50 -0000 On 2021-08-23 1:36 p.m., Patrick Monnerat wrote: > > On 8/23/21 6:26 PM, Simon Marchi wrote: >> Can you show to the >> corresponding change in Insight? I'm curious to see how Insight uses >> this. >> > Hi Simon, > > Sure! Here is the important part of the Insight diff: > > ----- > > --- a/gdbtk/generic/gdbtk-hooks.c > +++ b/gdbtk/generic/gdbtk-hooks.c > > @@ -685,16 +685,19 @@ gdbtk_post_add_symbol (void) > /* This hook function is called whenever we want to wait for the > target. */ > > -static ptid_t > -gdbtk_wait (ptid_t ptid, struct target_waitstatus *ourstatus, void *options) > +static void > +gdbtk_waiting_for_target (bool enter, ptid_t ptid) > { > - gdbtk_force_detach = 0; > - gdbtk_start_timer (); > - ptid = target_wait (ptid, ourstatus, *(target_wait_flags *) options); > - gdbtk_stop_timer (); > - gdbtk_ptid = ptid; > - > - return ptid; > + if (enter) > + { > + gdbtk_force_detach = 0; > + gdbtk_start_timer (); > + } > + else > + { > + gdbtk_stop_timer (); > + gdbtk_ptid = ptid; > + } > } > > /* > ----- > > For more details, see Insight commit https://sourceware.org/git/?p=insight.git;a=commit;h=16042bf Thanks, that clarifies why you need it to be called both before and after. I think it would be good to add some comment above where the obsserver is notified to say that this is used by Insight, otherwise someone might be tempted to remove it, as it is unused in the GDB project itself. I suggest leaving the review up for a week, if nobody has objections, I'll merge your patch (and I can add the comment myself). Thanks, Simon