From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/2] Remove argument pc in get_next_pcs
Date: Fri, 15 Jan 2016 13:14:00 -0000 [thread overview]
Message-ID: <5698F0C2.70105@ericsson.com> (raw)
In-Reply-To: <1452851849-24127-1-git-send-email-yao.qi@linaro.org>
On 01/15/2016 04:57 AM, Yao Qi wrote:
> Hi,
> get_next_pcs in struct linux_target_ops has two arguments, PC and
> REGCACHE. Since PC can be got from REGCACHE, PC is redundant, so this
> patch series remove it in various places. After the removal, PC is
> got from regcache via regcache_read_pc, so patch #1 uses
> regcache_read_pc out of *the_low_target.get_next_pcs. Then, patch #2
> removes PC arguments and PC can be got inside the implementations of
> get_next_pcs via regcache_read_pc.
>
> Regression tested on arm-linux.
>
> *** BLURB HERE ***
>
> Yao Qi (2):
> [GDBserver] Use regcache_read_pc in
> install_software_single_step_breakpoints
> Remove argument pc in get_next_pcs
>
> gdb/arch/arm-get-next-pcs.c | 24 +++++++++++++-----------
> gdb/arch/arm-get-next-pcs.h | 3 +--
> gdb/arm-linux-tdep.c | 2 +-
> gdb/arm-tdep.c | 2 +-
> gdb/gdbserver/linux-arm-low.c | 4 ++--
> gdb/gdbserver/linux-low.c | 3 +--
> gdb/gdbserver/linux-low.h | 2 +-
> 7 files changed, 20 insertions(+), 20 deletions(-)
>
LGTM, thanks for the patches.
Regards,
Antoine
next prev parent reply other threads:[~2016-01-15 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 9:57 Yao Qi
2016-01-15 9:57 ` [PATCH 2/2] " Yao Qi
2016-01-15 9:57 ` [PATCH 1/2] [GDBserver] Use regcache_read_pc in install_software_single_step_breakpoints Yao Qi
2016-01-15 13:14 ` Antoine Tremblay [this message]
2016-01-26 14:09 ` [PATCH 0/2] Remove argument pc in get_next_pcs Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5698F0C2.70105@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).