From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53745 invoked by alias); 18 Jan 2016 14:02:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53720 invoked by uid 89); 18 Jan 2016 14:02:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:1045, $pc, pc, sigstepexp X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 18 Jan 2016 14:02:35 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 4C.B3.32102.960FC965; Mon, 18 Jan 2016 15:02:17 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Mon, 18 Jan 2016 09:02:33 -0500 Subject: Re: [PATCH v8 3/7] Refactor arm_software_single_step to use regcache To: Yao Qi References: <1450361684-29536-1-git-send-email-antoine.tremblay@ericsson.com> <1450361684-29536-4-git-send-email-antoine.tremblay@ericsson.com> <86oacjtbue.fsf@gmail.com> <86h9ibt4sg.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <569CF078.4010806@ericsson.com> Date: Mon, 18 Jan 2016 14:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <86h9ibt4sg.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00378.txt.bz2 On 01/18/2016 08:07 AM, Yao Qi wrote: > Yao Qi writes: > >> As a record, this patch causes regressions at least in >> gdb.base/sigstep.exp, >> >> (gdb) PASS: gdb.base/sigstep.exp: continue to handler, si+advance in >> handler, step from handler: advance in handler >> step^M >> 39 } /* handler */^M >> 1: x/i $pc^M >> => 0x8740 : sub sp, r11, #0^M >> (gdb) step^M >> ^M >> Program received signal SIGSEGV, Segmentation fault.^M >> setitimer () at ../sysdeps/unix/syscall-template.S:81^M >> 81 ../sysdeps/unix/syscall-template.S: No such file or directory.^M >> 1: x/i $pc^M >> => 0xb6eff9c0 : push {r7}^M >> (gdb) FAIL: gdb.base/sigstep.exp: continue to handler, si+advance in >> handler, step from handler: leave handler >> >> Could you take a look at it? > > Here is my patch fixing the regression in sigstep.exp. The regression > test is running now. > You've beat me to it, thanks for the fix ! Patch LGTM. Regards, Antoine