From: Simon Marchi <simon.marchi@ericsson.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <palves@redhat.com>, <dejagnu@gnu.org>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: How to abort a test?
Date: Mon, 18 Jan 2016 16:43:00 -0000 [thread overview]
Message-ID: <569D163D.7060609@ericsson.com> (raw)
In-Reply-To: <20160117082709.GC4059@adacore.com>
On 16-01-17 03:27 AM, Joel Brobecker wrote:
> I admit that some of it flying a little over my head... Does it
> mean that we will be able to abort a test if we detect a timeout?
> This is one of the things I wanted to do, but didn't have a solution
> for, so it'd be fantastic if it helped with that!
--status does no really impact how a timeout is handled. What happens
when a timeout occurs in gdb_test is defined by us. Right now, it
produces a test "fail":
testsuite/lib/gdb.exp:
937 timeout {
938 if ![string match "" $message] then {
939 fail "$message (timeout)"
940 }
941 set result 1
942 }
So you see, for example:
FAIL: gdb.base/break.exp: some test (timeout)
and the test case carries on. A gdb_test timeout is no different than
a regular fail. If you replace the "fail" at line 939 with "error",
which throws a TCL exception, then the current test case will abort,
although in this quite ugly way:
Running /home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.base/break.exp ...
ERROR OCCURED: some test (timeout)
while executing
"error "$message (timeout)""
invoked from within
"if ![string match "" $message] then {
error "$message (timeout)"
}"
invoked from within
"expect {
-i exp8 -timeout 1
-re ".*A problem internal to GDB has been detected" {
fail "$message (GDB internal error)"
gdb_internal_error_..."
("uplevel" body line 1)
invoked from within
"uplevel $body" NONE insert breakpoint (timeout)WARNING: remote_expect statement without a default case?!
The current test case is stopped and the next .exp is ran. However,
if you don't use --status on the runtest command line, the uncaught
exception will not be considered as an error. So if you use
"make check" in a script, you won't notice the failure.
next prev parent reply other threads:[~2016-01-18 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 22:51 Simon Marchi
2016-01-14 16:25 ` Pedro Alves
2016-01-14 17:13 ` Simon Marchi
2016-01-14 17:28 ` Pedro Alves
2016-01-14 19:43 ` Simon Marchi
2016-01-14 19:48 ` Pedro Alves
2016-01-15 16:35 ` Simon Marchi
2016-01-15 20:22 ` Ben Elliston
2016-01-17 8:27 ` Joel Brobecker
2016-01-18 16:43 ` Simon Marchi [this message]
2016-01-21 10:42 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D163D.7060609@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=brobecker@adacore.com \
--cc=dejagnu@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).