From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] testsuite: Remove unused global references in gdb_test
Date: Mon, 18 Jan 2016 16:58:00 -0000 [thread overview]
Message-ID: <569D19C0.40805@ericsson.com> (raw)
In-Reply-To: <569D12AE.6060703@redhat.com>
On 16-01-18 11:28 AM, Pedro Alves wrote:
>> ---
>> gdb/testsuite/lib/gdb.exp | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
>> index 52220d0..f3f53b7 100644
>> --- a/gdb/testsuite/lib/gdb.exp
>> +++ b/gdb/testsuite/lib/gdb.exp
>> @@ -976,10 +976,7 @@ proc gdb_test_multiple { command message user_code } {
>> # -1 if there was an internal error.
>> #
>> proc gdb_test { args } {
>> - global verbose
>> global gdb_prompt
>> - global GDB
>> - upvar timeout timeout
>
> The upvar should stay. I think this just follows standard procedure
> for expect:
>
> http://www.tcl.tk/man/expect5.31/expect.1.html
>
> "Expect takes a rather liberal view of scoping. In particular, variables read
> by commands specific to the Expect program will be sought first from the
> local scope, and if not found, in the global scope. For example, this obviates
> the need to place "global timeout" in every procedure you write that uses expect."
>
> See also get_largest_timeout.
>
> So gdb_test_multiple will look at the timeout in the caller, which will be
> gdb_test. And this upvar then makes gdb_test_multiple actually look at the
> timeout variable in gdb_test's caller frame.
Ahh, thanks. I knew there was something.
I pushed it with "upvar timeout timeout" kept.
From cdd9114f5737fdfbb3c828af3a118fec8aafc26f Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 18 Jan 2016 11:08:12 -0500
Subject: [PATCH] testsuite: Remove unused global references in gdb_test
Those are unused since gdb_test_multiple was added, factoring out most
of the content of gdb_test.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (gdb_test): Remove unused global references.
---
gdb/testsuite/lib/gdb.exp | 2 --
1 file changed, 2 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 52220d0..e6fe62c 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -976,9 +976,7 @@ proc gdb_test_multiple { command message user_code } {
# -1 if there was an internal error.
#
proc gdb_test { args } {
- global verbose
global gdb_prompt
- global GDB
upvar timeout timeout
if [llength $args]>2 then {
--
2.5.1
prev parent reply other threads:[~2016-01-18 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 16:14 Simon Marchi
2016-01-18 16:28 ` Pedro Alves
2016-01-18 16:58 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D19C0.40805@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).