Re: [PATCH 1/2] Fix sorting of enum values in FlagEnumerationPrinter

[Pedro Alves <palves@redhat.com>]

Thanks for catching this.

I find it surprising that the printer doesn't respect the
order of the values as they're defined though.  Shouldn't we
remove the sort line entirely, thus keeping the
existing behavior?  I couldn't find mention of the sorting
in the documentation either.

Or, maybe the printer doesn't work correctly if the "overlapping"
value (which I think it the whole point of this printer) is defined
before the particular values, like, e.g.:

 enum flag_enum
   {
     ALL = 1 | 2 | 4,
     FLAG_2 = 2,
     FLAG_3 = 4,
     FLAG_1 = 1,
   };

?

On 01/19/2016 04:23 AM, Simon Marchi wrote:

> +
>  enum flag_enum
>    {
> -    FLAG_1 = 1,
> +    /* Define the enumration values in an unsorted manner to verify that we
> +       effectively sort them by value.  */

typo: "enumration".

Thanks,
Pedro Alves