From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@freebsd.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Use a separate variable for the size passed to sysctl.
Date: Tue, 19 Jan 2016 22:53:00 -0000 [thread overview]
Message-ID: <569EBE5F.2070100@redhat.com> (raw)
In-Reply-To: <1679587.CEfXXqWAZn@ralph.baldwin.cx>
On 01/19/2016 07:35 PM, John Baldwin wrote:
> On Tuesday, January 19, 2016 07:18:49 PM Pedro Alves wrote:
>> OK with ...
>>
>> On 01/19/2016 06:24 PM, John Baldwin wrote:
>>> --- a/gdb/ChangeLog
>>> +++ b/gdb/ChangeLog
>>> @@ -1,5 +1,10 @@
>>> 2016-01-19 John Baldwin <jhb@FreeBSD.org>
>>>
>>> + * fbsd-tdep.c (fbsd_pid_to_exec_file): Use new "buflen" instead of
>>> + "len" with sysctl.
>>
>> ... should be "fbsd-nat.c".
>
> Err, yes. I also noticed after mailing that the 'len' variable is now
> initialized unnecessarily (since it's value is always overwritten by the
> call to readlink() after the #endif). Is it ok to push this modified
> version:
Yes, of course.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-01-19 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 18:29 John Baldwin
2016-01-19 19:18 ` Pedro Alves
2016-01-19 19:36 ` John Baldwin
2016-01-19 22:53 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569EBE5F.2070100@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).