From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89071 invoked by alias); 19 Jan 2016 22:53:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89062 invoked by uid 89); 19 Jan 2016 22:53:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=unnecessarily X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Jan 2016 22:53:21 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 364F38F89E; Tue, 19 Jan 2016 22:53:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0JMrJLX020705; Tue, 19 Jan 2016 17:53:19 -0500 Message-ID: <569EBE5F.2070100@redhat.com> Date: Tue, 19 Jan 2016 22:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: John Baldwin CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Use a separate variable for the size passed to sysctl. References: <1453227896-65820-1-git-send-email-jhb@FreeBSD.org> <569E8C19.5060206@redhat.com> <1679587.CEfXXqWAZn@ralph.baldwin.cx> In-Reply-To: <1679587.CEfXXqWAZn@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00463.txt.bz2 On 01/19/2016 07:35 PM, John Baldwin wrote: > On Tuesday, January 19, 2016 07:18:49 PM Pedro Alves wrote: >> OK with ... >> >> On 01/19/2016 06:24 PM, John Baldwin wrote: >>> --- a/gdb/ChangeLog >>> +++ b/gdb/ChangeLog >>> @@ -1,5 +1,10 @@ >>> 2016-01-19 John Baldwin >>> >>> + * fbsd-tdep.c (fbsd_pid_to_exec_file): Use new "buflen" instead of >>> + "len" with sysctl. >> >> ... should be "fbsd-nat.c". > > Err, yes. I also noticed after mailing that the 'len' variable is now > initialized unnecessarily (since it's value is always overwritten by the > call to readlink() after the #endif). Is it ok to push this modified > version: Yes, of course. Thanks, Pedro Alves