From: Pedro Alves <palves@redhat.com>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>,
eliz@gnu.org, brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V3 1/6] Merges gdb and gdbserver implementation for siginfo.
Date: Wed, 20 Jan 2016 15:42:00 -0000 [thread overview]
Message-ID: <569FAAD2.3050507@redhat.com> (raw)
In-Reply-To: <1453105544-30866-2-git-send-email-walfred.tedeschi@intel.com>
In $subject: please use imperative "Merge". Also, "implementations",
plural. (Please drop periods in subject lines while at it).
On 01/18/2016 08:25 AM, Walfred Tedeschi wrote:
> The compatible siginfo handling from amd64-linux-nat.c and
> gdbserver/linux-x86-low were extracted it into a new file
> nat/amd64-linux-siginfo.c.
I suggest:
Extract the compatible siginfo handling from amd64-linux-nat.c and
gdbserver/linux-x86-low to a new file nat/amd64-linux-siginfo.c.
>
>
> 2016-01-15 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> gdb/ChangeLog:
>
> * nat/amd64-linux-siginfo.c: New file.
> * nat/amd64-linux-siginfo.h: New file.
> * Makefile.in (HFILES_NO_SRCDIR): Add nat/amd64-linux-siginfo.h.
> Add native object files rule for
This "Add native..." sentence looks stray/unfinished. Also, if it stays,
please align it with a single tab (you have an extra suprious space).
> (amd64-linux-siginfo.o): New rule.
> * config/i386/linux64.mh (NATDEPFILES): Add amd64-linux-siginfo.o.
> * amd64-linux-nat.c (nat/amd64-linux-siginfo.h): New include.
> (compat_siginfo_from_siginfo, siginfo_from_compat_siginfo)
> (compat_x32_siginfo_from_siginfo, siginfo_from_compat_x32_siginfo)
> (and collateral structures): Move to nat/amd64-linux-siginfo.c.
Please spell out the structures names instead of the "and collateral
structures" bit.
>
>
> gdb/gdbserver/ChangeLog:
>
> * configure.srv (x86_64-*-linux*): Add amd64-linux-siginfo.o
> to srv_tgtobj.
> (i[34567]86-*-linux*): Add amd64-linux-siginfo.o
> to srv_tgtobj.
> * linux-x86-low.c [__x86_64__]: Include
> "nat/mad64-linux-siginfo.h".
Typo "mad64".
> (compat_siginfo_from_siginfo, siginfo_from_compat_siginfo)
> (compat_x32_siginfo_from_siginfo, siginfo_from_compat_x32_siginfo)
> (and collateral structures): Move to nat/amd64-linux-siginfo.c.
See above.
> * Makefile.in (amd64-linux-siginfo.o:): New rule.
> +
> +/* Converts the system provided siginfo into compatible siginfo. */
Say "Convert". Also, please leave an empty line between intro command
and function definition.
> +static void
> +compat_siginfo_from_siginfo (compat_siginfo_t *to, siginfo_t *from)
> +{
> +
> +/* Converts the compatible siginfo into system siginfo. */
> +static void
> +siginfo_from_compat_siginfo (siginfo_t *to, compat_siginfo_t *from)
Ditto.
> +/* Converts the system provided siginfo into compatible x32 siginfo. */
> +static void
> +compat_x32_siginfo_from_siginfo (compat_x32_siginfo_t *to,
> + siginfo_t *from)
Ditto.
> +
> +/* Converts the compatible x32 siginfo into system siginfo. */
> +static void
> +siginfo_from_compat_x32_siginfo (siginfo_t *to,
> + compat_x32_siginfo_t *from)
Ditto.
Otherwise OK.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-01-20 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 8:25 [PATCH V3 0/6] Intel MPX bound violation support Walfred Tedeschi
2016-01-18 8:25 ` [PATCH V3 3/6] Use linux_get_siginfo_type_with_fields for x86 Walfred Tedeschi
2016-01-20 18:57 ` Pedro Alves
2016-01-18 8:25 ` [PATCH V3 2/6] Prepararion for new siginfo on Linux Walfred Tedeschi
2016-01-20 18:56 ` Pedro Alves
2016-01-18 8:26 ` [PATCH V3 4/6] Add bound related fields to the siginfo structure Walfred Tedeschi
2016-01-20 18:57 ` Pedro Alves
2016-01-18 8:26 ` [PATCH V3 5/6] Adaptation of siginfo fixup for the new bnd fields Walfred Tedeschi
2016-01-18 8:26 ` [PATCH V3 6/6] Intel MPX bound violation handling Walfred Tedeschi
2016-01-18 8:26 ` [PATCH V3 1/6] Merges gdb and gdbserver implementation for siginfo Walfred Tedeschi
2016-01-20 15:42 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FAAD2.3050507@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).