public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [testsuite] Make the testsuite work on mingw
Date: Thu, 15 Aug 2019 15:56:00 -0000	[thread overview]
Message-ID: <569e37f9-0e82-2565-f150-1fe50e76cc1e@redhat.com> (raw)
In-Reply-To: <20190814231502.78501-1-cbiesinger@google.com>

On 8/15/19 12:15 AM, Christian Biesinger via gdb-patches wrote:
> Dejagnu produces an objdir like /c/, but GDB expects something like c:/.
> So fix it up in lib/gdb.exp.
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-08-14  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* lib/gdb.exp: When running on a mingw target, replace
> 	/x/ with x:/.
> ---
>  gdb/testsuite/lib/gdb.exp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index edc8dfcdfd..af56e8aa12 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -4724,6 +4724,10 @@ proc standard_output_file {basename} {
>  
>      set dir [make_gdb_parallel_path outputs $subdir $gdb_test_file_name]
>      file mkdir $dir
> +    # If running on MinGW, replace /c/foo with c:/foo

OOC, does "on MinGW" mean using a Cygwin or MSYS2 dejagnu?

Or are you really using a native MinGW expect/dejagnu?

> +    if { [ishost *-*-mingw*] } {
> +        set dir [regsub {^/([a-z])/} $dir {\1:/}]
> +    }
>      return [file join $dir $basename]
>  }
>  
> 

Thanks,
Pedro Alves

  parent reply	other threads:[~2019-08-15 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 23:15 Christian Biesinger via gdb-patches
2019-08-15  1:47 ` Kevin Buettner
2019-08-15 15:56 ` Pedro Alves [this message]
2019-08-15 16:15   ` Christian Biesinger via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569e37f9-0e82-2565-f150-1fe50e76cc1e@redhat.com \
    --to=palves@redhat.com \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).