From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-158189-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 114338 invoked by alias); 15 Aug 2019 15:56:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 114330 invoked by uid 89); 15 Aug 2019 15:56:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO: mail-wm1-f42.google.com
Received: from mail-wm1-f42.google.com (HELO mail-wm1-f42.google.com) (209.85.128.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 15:56:43 +0000
Received: by mail-wm1-f42.google.com with SMTP id 10so1685255wmp.3        for <gdb-patches@sourceware.org>; Thu, 15 Aug 2019 08:56:42 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id l15sm2742325wru.56.2019.08.15.08.56.40        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Thu, 15 Aug 2019 08:56:40 -0700 (PDT)
Subject: Re: [PATCH] [testsuite] Make the testsuite work on mingw
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
References: <20190814231502.78501-1-cbiesinger@google.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <569e37f9-0e82-2565-f150-1fe50e76cc1e@redhat.com>
Date: Thu, 15 Aug 2019 15:56:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190814231502.78501-1-cbiesinger@google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-08/txt/msg00326.txt.bz2

On 8/15/19 12:15 AM, Christian Biesinger via gdb-patches wrote:
> Dejagnu produces an objdir like /c/, but GDB expects something like c:/.
> So fix it up in lib/gdb.exp.
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-08-14  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* lib/gdb.exp: When running on a mingw target, replace
> 	/x/ with x:/.
> ---
>  gdb/testsuite/lib/gdb.exp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index edc8dfcdfd..af56e8aa12 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -4724,6 +4724,10 @@ proc standard_output_file {basename} {
>  
>      set dir [make_gdb_parallel_path outputs $subdir $gdb_test_file_name]
>      file mkdir $dir
> +    # If running on MinGW, replace /c/foo with c:/foo

OOC, does "on MinGW" mean using a Cygwin or MSYS2 dejagnu?

Or are you really using a native MinGW expect/dejagnu?

> +    if { [ishost *-*-mingw*] } {
> +        set dir [regsub {^/([a-z])/} $dir {\1:/}]
> +    }
>      return [file join $dir $basename]
>  }
>  
> 

Thanks,
Pedro Alves