From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87015 invoked by alias); 21 Jan 2016 15:05:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86610 invoked by uid 89); 21 Jan 2016 15:05:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Jan 2016 15:05:29 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 3AB25A37AA; Thu, 21 Jan 2016 15:05:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0LF5QPp014529; Thu, 21 Jan 2016 10:05:27 -0500 Message-ID: <56A0F3B6.6020709@redhat.com> Date: Thu, 21 Jan 2016 15:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Walfred Tedeschi , eliz@gnu.org, brobecker@adacore.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH V4 2/6] Prepararion for new siginfo on Linux. References: <1453387705-6597-1-git-send-email-walfred.tedeschi@intel.com> <1453387705-6597-3-git-send-email-walfred.tedeschi@intel.com> In-Reply-To: <1453387705-6597-3-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00530.txt.bz2 This looks just like the same patch in v3, and my review comments [1] were not addressed. As this is recurring, I have to call it out, sorry -- please make sure to review past review comments carefully before resubmitting. If you don't agree to some review comment and decide to do things differently, reply to the review saying so. In any case, it's useful to reply anyway, saying "I'll fix", or some such, so that there's a feedback loop. [1] https://sourceware.org/ml/gdb-patches/2016-01/msg00490.html Thanks, Pedro Alves