From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] PR 18303, Tolerate malformed input for lookup_symbol-called functions.
Date: Thu, 28 Jan 2016 12:06:00 -0000 [thread overview]
Message-ID: <56AA044A.8040900@redhat.com> (raw)
In-Reply-To: <1453944094-31885-1-git-send-email-donb@codesourcery.com>
On 01/28/2016 01:21 AM, Don Breazeal wrote:
> The patch includes three new tests related to this. One is just
> gdb.linespec/ls-errs.exp copied and converted to use C++ instead of C, and
> to add a case using a file name containing a Windows-style logical drive
> specifier.
....
> gdb/testsuite/gdb.linespec/ls-errs-cp.cc | 36 +++++
> gdb/testsuite/gdb.linespec/ls-errs-cp.exp | 240 ++++++++++++++++++++++++++++
...
Can't we somehow reuse the existing test? Say, either:
- move the main body of ls-errs.exp a procedure, and call it twice,
once for each language, or,
- make gdb.linespec/ls-errs-cp.exp set some $language var and then
source gdb.linespec/ls-errs.exp, like gdb.base/checkpoint-ns.exp.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-01-28 12:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 22:34 [PATCH] Fix problem handling colon in linespec, PR breakpoints/18303 Doug Evans
2016-01-12 0:17 ` Don Breazeal
2016-01-12 18:26 ` Keith Seitz
2016-01-25 17:26 ` [PING] " Don Breazeal
2016-01-26 16:56 ` Doug Evans
2016-01-28 1:21 ` [PATCH v2] PR 18303, Tolerate malformed input for lookup_symbol-called functions Don Breazeal
2016-01-28 12:06 ` Pedro Alves [this message]
2016-01-28 22:43 ` [PATCH v3] " Don Breazeal
2016-01-28 22:52 ` [PATCH v4] " Don Breazeal
2016-02-04 18:37 ` [PING] " Don Breazeal
2016-02-18 18:22 ` [PING] Re: [PATCH v4] PR 18303, Tolerate malformed input for lookup_symbol-called functions (was: [PATCH] Fix problem handling colon in linespec, PR breakpoints/18303) Don Breazeal
2016-02-25 17:28 ` [PING] Re: [PATCH v4] PR 18303, Tolerate malformed input for lookup_symbol-called functions Don Breazeal
2016-03-03 18:19 ` Don Breazeal
2016-03-14 21:23 ` [PING] Re: [PATCH v4] PR 18303, Tolerate malformed input for lookup_symbol-called functions (was: Re: [PATCH] Fix problem handling colon in linespec, PR breakpoints/18303) Don Breazeal
2016-03-15 15:55 ` [PING] Re: [PATCH v4] PR 18303, Tolerate malformed input for lookup_symbol-called functions Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA044A.8040900@redhat.com \
--to=palves@redhat.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).